Hide Forgot
It's make sense to reject incomplete packages. But wrong error msg is always confusing people. eg. https://hardware.redhat.com/show.cgi?id=681454#c12 The rpm is incomplete, but catalog reported as unknow v7 version.
Created attachment 513719 [details] the 1st patch
please review this, I have applied patch on web2
hwcert.pl Lines 1032 - change is not related to this bug. Lines 1230 - can the line be updated for readability? Eg. right now is says do c unless a = b; which is harder to read than if a = b do c (the abc ordering is more important than the keyword selection). Yes they should function the same, but when reviewing code c is least interesting part not the most as the conditional matters more and if possible should be presented 1st. user-error.html.tmpl - is this a user error? line 410 - how about "The test suite version not found in INFO test." ; if there are no INFO tests that should be it's own error.
Lines 1032 yes, that is not related, I can drop this change Lines 1230 I don't think this is a system error, user uploaded a wrong format of package, I think it should be a user error. line 410 "The test suite version not found in INFO test." seems not able to cover no info tests case. in the sample cert which xqin reported, it is caused by no info tests in package. it is too vague to say "The test suite version not found in INFO test."
(In reply to comment #7) > Lines 1230 I don't think this is a system error, user uploaded a wrong format > of package, I think it should be a user error. Ok > line 410 "The test suite version not found in INFO test." seems not able to > cover no info tests case. in the sample cert which xqin reported, it is caused > by no info tests in package. it is too vague to say "The test suite version not > found in INFO test." Actually that's my point, there should be two errors. 1) version not found in INFO test and 2) the package appears correctly formed but there is no info test found.
the message has changed to what Rob suggested
Is there a patch/test site?
works on web2 test result package: https://bugzilla.redhat.com/attachment.cgi?id=482711