Hide Forgot
Spec URL: http://people.redhat.com/varekova/man-pages-overrides.spec SRPM URL: http://people.redhat.com/varekova/man-pages-overrides-0.5.7.0-1.fc13.src.rpm Description: A collection of manual ("man") pages to complement other packages or update those contained therein. Always have the latest version of this package installed.
Looks fine. A few notes: * License: is OK - but ONLY IF you plan to update it with each included man page * %description: "Always have the latest version of this package installed." This feels a little strange - users can't read such instructions during installation, anyway. There's nothing technically wrong with it, of course. * I'd feel a little bit more comfortable if the %doc path and directory name were not hard-coded in the spec like this (so that nothing needed to be changed if RPM changed policy for locating or naming the %doc directories), but it's probably not worth the effort. * Consider changing %install to preserve timestamps of installed files. rpmlint: > man-pages-overrides.src: W: no-url-tag > man-pages-overrides.src: W: invalid-url Source0: man-pages-overrides-0.5.7.0.tar.gz OK > man-pages-overrides.src: W: no-%build-section I'd suggest adding a %build section (empty or only containing a comment) for clarity. > man-pages-overrides.noarch: E: invalid-locale-man-dir /usr/share/man/overrides/man1/apropos.1.gz > man-pages-overrides.noarch: W: file-not-in-%lang /usr/share/man/overrides/man1/apropos.1.gz False positives - perhaps worth filing a rpmlint bug.