Bug 684005 - improper handling of bad date format in tcpslice.c
Summary: improper handling of bad date format in tcpslice.c
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: tcpdump
Version: 6.1
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: rc
: ---
Assignee: Jan Synacek
QA Contact: Ondrej Moriš
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-10 21:43 UTC by Kamil Dudka
Modified: 2012-04-19 03:26 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Do not document
Clone Of:
Environment:
Last Closed: 2012-03-26 12:15:09 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0414 0 normal SHIPPED_LIVE tcpdump bug fix update 2012-03-26 16:13:38 UTC

Description Kamil Dudka 2011-03-10 21:43:47 UTC
Description of problem:
--- a/tcpslice-1.2a3/tcpslice.c
+++ b/tcpslice-1.2a3/tcpslice.c
@@ -404,7 +404,7 @@

        while (isdigit(*t_stop))
            ++t_stop;
-       if (! t_stop)
+       if (! *t_stop)
            error("bad date format %s, problem starting at %s",
                  time_string, t_start);


Version-Release number of selected component (if applicable):
tcpdump-4.0.0-3.20090921gitdf3cb4.1.el6


Additional info:
http://cwe.mitre.org/data/definitions/476.html

Comment 3 RHEL Program Management 2011-03-10 22:17:50 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 15 Michal Fojtik 2012-02-06 10:46:20 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously, the "start-time" command-line argument of the tcpslice utility was parsed incorrectly. As a consequence, the utility produced error messages every time the command-line argument was used. With this update, the "start-time" command-line argument is parsed correctly, and an error message is displayed only if "start-time" is defined in an incorrect format.

Comment 17 Kamil Dudka 2012-02-06 11:14:53 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-Previously, the "start-time" command-line argument of the tcpslice utility was parsed incorrectly. As a consequence, the utility produced error messages every time the command-line argument was used. With this update, the "start-time" command-line argument is parsed correctly, and an error message is displayed only if "start-time" is defined in an incorrect format.+Do not document

Comment 18 Michal Luscon 2012-02-20 13:14:08 UTC
REVERSE_INULL defect is now fixed in tcpdupm-4.0.0 - confirmed by the Coverity  scan of rhel-6.3. If there is no other reason to keep this report, it may be closed.

Comment 20 errata-xmlrpc 2012-03-26 12:15:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0414.html


Note You need to log in before you can comment on or make changes to this bug.