Hide Forgot
Description of problem: - suspicious call of blkend() with no effect - suspicious assignments to variable 'res' with no effect Version-Release number of selected component (if applicable): tcsh-6.17-12.el6
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative.
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Prior to this update, the blkend() function was called redundantly in the tsch code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.
Created attachment 528577 [details] defects fixed in tcsh-6.17-13.el6
Created attachment 528578 [details] defects added in tcsh-6.17-13.el6
Comment on attachment 528578 [details] defects added in tcsh-6.17-13.el6 >Error: FORWARD_NULL: >/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:734: var_compare_op: Comparing "t->t_dcom" to null implies that "t->t_dcom" might be null. >/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:740: var_deref_model: Passing null variable "t->t_dcom" to function "padd", which dereferences it. >/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:820: var_assign_parm: Assigning: "argp" = "t->t_dcom". >/builddir/build/BUILD/tcsh-6.17.00/sh.proc.c:820: deref_var: Dereferencing "argp", which equals a pointer parameter. This defect ^^^ is not a regression. It is either a false positive, or an old bug revealed by the tcsh-6.17.00-status-pipeline-backquote-list-of-cmds.patch.
Thanks Kamil. I'm looking at the defects right now, I'm going to fix it soon..
The original glob-automount patch has also some design issues, not only those coverity failures. We are now testing the possible solutions with QA assignee..
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1 @@ -Prior to this update, the blkend() function was called redundantly in the tsch code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.+Prior to this update, the blkend() function was called redundantly in the tcsh code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.
Deleted Technical Notes Contents. Old Contents: Prior to this update, the blkend() function was called redundantly in the tcsh code. These calls had no effect on tcsh functionality and thus they have been removed. Tcsh functionality remains unchanged and the code is now more effective.
*** Bug 734357 has been marked as a duplicate of this bug. ***
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1686.html