Hide Forgot
Created attachment 483626 [details] the sample rpm Description of problem: The 'make' in results.xml is null Version-Release number of selected component (if applicable): 1.2.25 How reproducible: Steps to Reproduce: 1. download an rpm produced by v7 1.2.25,extract it and look at the make tag 2. 3. Actual results: it is null Expected results: there is a make Additional info:
What should it be set to? v7 currently does not set "make" to anything. We use dmidecode to set "vendor" and "model", failing that, we check /proc/device-tree/model, or use arch for some IBM systems' vendor. If none of that works, v7 will prompt the user for vendor and model.
Looks like we can use the 2nd word in product name; where the 3rd is model. 1st seems to be a version of vendor. Product Name: HP EliteBook 8560w Product Name: Lenovo ThinkServer TS430 (I'm not certain how representative the above two random examples are.) Instead of presuming v7/dmidecode got it right with the only option being to hand edit results.xml when it isn't could v7 prompt the user providing a default of what it finds this way the user could confirm/correct the values?
Created attachment 511761 [details] hardware test patch adding verification prompts for vendor, make and model
Created attachment 511762 [details] patch for new promptEdit method to support editing default values
Example log of the above patches: [root@blueshirt v7]# v7 plan Please verify the vendor, make, and model: Vendor: LENOVO Make: Thinkpad Model: T500 2241B36 Hardware: LENOVO Thinkpad T500 2241B36 In this example, the field defaults were: Vendor: LENOVO Make: Model: 2241B36
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: in v7 1.4, an enhancement has been made that on first run v7 will prompt user to verify vendor, make and model and allow user to edit the default values. These values will be stored in results.xml
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1436.html