Bug 684712 - Creating a storage pool with unsupported format type makes libvirtd dead
Summary: Creating a storage pool with unsupported format type makes libvirtd dead
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.1
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Osier Yang
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-14 10:11 UTC by Vivian Bian
Modified: 2014-03-27 01:02 UTC (History)
8 users (show)

Fixed In Version: libvirt-0.8.7-13.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 13:28:56 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0596 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2011-05-18 17:56:36 UTC

Description Vivian Bian 2011-03-14 10:11:19 UTC 
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a storage pool with unsupported format type , such as "asdf"
2. check the libvirtd status
3.
  
Actual results:
# virsh pool-define pool.xml;service libvirtd status
error: Failed to define pool from pool.xml
error: server closed connection: 

libvirtd dead but pid file exists



Expected results:
Could tell the format type is not supported , and don't kill libvirtd 

Additional info:
Example XML 

<pool type='disk'>
  <name>sdb</name>
  <source>
    <device path='/dev/sdb'>
    </device>
    <format type='auto'/>
  </source>
  <target>
    <path>/dev</path>
    <permissions>
      <mode>0700</mode>
      <owner>0</owner>
      <group>0</group>
    </permissions>
  </target>
</pool>
Comment 2 Osier Yang 2011-03-16 07:03:59 UTC 
patch posted upstream: 

http://www.redhat.com/archives/libvir-list/2011-March/msg00742.html
Comment 3 Osier Yang 2011-03-16 08:39:35 UTC 
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-March/msg00366.html

patch posted internally, move to POST.
Comment 6 Nan Zhang 2011-03-17 05:24:31 UTC 
It can also reproduced with latest build.

# rpm -q libvirt qemu-kvm kernel
libvirt-0.8.7-12.el6.x86_64
qemu-kvm-0.12.1.2-2.150.el6.x86_64
kernel-2.6.32-120.el6.x86_64

# cat pool.xml 
<pool type='disk'>
  <name>sdb</name>
  <source>
    <device path='/dev/sdb'/>
    <format type='XXXX'/>
  </source>
  <target>
    <path>/dev</path>
      <permissions>
        <mode>0700</mode>
        <owner>0</owner>
        <group>0</group>
      </permissions>
  </target>
</pool>

# virsh pool-define pool.xml 
error: Failed to define pool from pool.xml
error: server closed connection: 

# service libvirtd status
libvirtd dead but pid file exists
Comment 7 Nan Zhang 2011-03-17 05:36:12 UTC 
Verified with libvirt-0.8.7-13.el6.x86_64, it's normal error info provided. Move to VERIFIED.

# rpm -q libvirt qemu-kvm kernel
libvirt-0.8.7-13.el6.x86_64
qemu-kvm-0.12.1.2-2.150.el6.x86_64
kernel-2.6.32-120.el6.x86_64

# virsh pool-define pool.xml 
error: Failed to define pool from pool.xml
error: XML description for unknown pool format type XXXX is not well formed or invalid

# service libvirtd status
libvirtd (pid  26317) is running...
Comment 10 errata-xmlrpc 2011-05-19 13:28:56 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html
Note You need to log in before you can comment on or make changes to this bug.