Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 684870

Summary: [Cisco 6.1 Bug Fix] libvirt 802.1Qbh: Add support for PREASSOCIATE_RR
Product: Red Hat Enterprise Linux 6 Reporter: roprabhu
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.1CC: agospoda, bsarathy, chrisw, cward, dallan, dyuan, eblake, gren, jyang, ndai, nzhang, vbian, xen-maint, yoyzhang
Target Milestone: rcKeywords: OtherQA
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-0.8.7-15.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 662245 Environment:
Last Closed: 2011-05-19 13:29:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 662245    
Bug Blocks: 665944, 678826, 679545    
Attachments:
Description Flags
Proposed patch for this bug none

Description roprabhu 2011-03-14 17:01:22 UTC 
Having a preassociate step to align with KVM migration prepare step helps 802.1qbh too. This helps with restoring network connectivity on source host if migration fails during the prepare step on destination host with our new 802.1qbh switches (Which is a bug we came across recently).

With new changes in ieee 802.1qbh/bg spec, 802.1qbh will need to move to VDP eventually. 
To fix the migration issue Enic driver for Cisco VIC adapter(802.1qbh) will have support for PREASSOCIATE_RR soon. This bug fix will add PREASSOCIATE_RR request support during 802.1qbh port profile association
Comment 3 Gary Case 2011-03-15 15:08:02 UTC 
From their email, Cisco believes that they'll be able to make the code available by March 21.
Comment 4 roprabhu 2011-03-22 18:15:01 UTC 
Created attachment 486866 [details]
Proposed patch for this bug

Attached is the libvirt patch for this bug.  The patch has not been posted upstream yet. Its waiting for enic (8021qbh) patches at https://bugzilla.redhat.com/show_bug.cgi?id=684865
Comment 5 Dave Allan 2011-03-22 18:23:32 UTC 
Please don't wait to post upstream, the feedback there will be extremely useful even if it's not committed.
Comment 6 roprabhu 2011-03-22 19:07:15 UTC 
ok thanks.
we were holding onto this patch because the corresponding enic patch for 802.1qbh is not out yet.

I went ahead and posted the patch upstream just now:
https://www.redhat.com/archives/libvir-list/2011-March/msg01034.html


Thanks dave.
Comment 7 roprabhu 2011-03-22 20:19:13 UTC 
Stefan has pushed the patch upstream. 
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=7708da38c7b58034bc792a387527f06a85ef83c7

Note that this patch has a dependency on bug  https://bugzilla.redhat.com/show_bug.cgi?id=684865
for rhel 6.1
Comment 8 Jiri Denemark 2011-03-24 14:27:34 UTC 
Posted: http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-March/msg00681.html
Comment 9 Jiri Denemark 2011-03-25 13:32:00 UTC 
This is not a real FutureFeature, it fixes a migration bug, though by making use of a new request.
Comment 11 Vivian Bian 2011-03-30 05:02:56 UTC 
Hi CISCO , 
Would you please update your pkgs to the version under http://veillard.com/libvirt/6.1/x86_64/ . And try if the bug is fixed already . 

Thanks
Vivian Bian
Comment 12 Chris Ward 2011-04-06 11:05:54 UTC 
~~ Partners and Customers ~~

This bug was included in RHEL 6.1 Beta. Please confirm the status of this request as soon as possible.

If you're having problems accessing 6.1 bits, are delayed in your test execution or find in testing that the request was not addressed adequately, please let us know.

Thanks!
Comment 13 dyuan 2011-04-28 09:06:07 UTC 
Download libvirt-0.8.7-18.el6.src.rpm, and libvirt-8021Qbh-use-preassociate-rr-during-the-migration-prepare-stage.patch can be found in /root/rpmbuild/SOURCES. and no critical regression and blocker was introduced in the latest build for migration.
Comment 16 roprabhu 2011-05-11 07:22:39 UTC 
Checked the libvirt src rpm on rhel 6.1 snap5. Pls consider this bug verified. Thanks
Comment 17 errata-xmlrpc 2011-05-19 13:29:00 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html