Bug 686236 - [vdsm] Passes wrong argument to qemu while using spice: -global qxl-vga.vram_size=67108864
Summary: [vdsm] Passes wrong argument to qemu while using spice: -global qxl-vga.vram_...
Keywords:
Status: CLOSED DUPLICATE of bug 673578
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: vdsm
Version: 6.1
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: rc
: ---
Assignee: Dan Kenigsberg
QA Contact: yeylon@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-15 14:15 UTC by Jakub Libosvar
Modified: 2016-04-18 06:39 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-15 17:20:29 UTC
Target Upstream Version:


Attachments (Terms of Use)
VM log & vdsm log (958.00 KB, application/x-gzip)
2011-03-15 14:15 UTC, Jakub Libosvar
no flags Details

Description Jakub Libosvar 2011-03-15 14:15:39 UTC
Created attachment 484779 [details]
VM log & vdsm log

Description of problem:
When using spice console, qemu process is run with parameter -global qxl-vga.vram_size=67108864 which is considered as invalid option and due to this parameter VM won't start

Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.150.el6.x86_64
vdsm-4.9-53.el6.x86_64
libvirt-0.8.7-11.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Create a new VM (in my case RHEL 6 x64, with virtio disk)
2. Set console as Spice
3. Run VM
  
Actual results:
run fails due to bad qemu parameters

Expected results:
VM is running

Additional info:
vnc works

critical parameters qemu is run with: -vga qxl -global qxl-vga.vram_size=67108864

Parameters passed from vdsm:
                        <model heads="1" type="qxl" vram="65536"/>
                </video>
                <channel type="spicevmc">
                        <target name="com.redhat.spice.0" type="virtio"/>
                </channel>
                <graphics autoport="yes" keymap="en-us" listen="0" passwd="*****" passwdValidTo="1970-01-01T00:00:01" port="-1" tlsPort="-1" type="spice">
                        <channel mode="secure" name="main"/>
                        <channel mode="secure" name="inputs"/>
                </graphics>

VM log and vdsm log is attached

Comment 2 Yaniv Kaul 2011-03-15 14:35:52 UTC
Looks like VDSM should ask libvirt for vram=64 (as libvirt translates it from megs to bytes).

Comment 4 Dan Kenigsberg 2011-03-15 14:58:08 UTC
Lovely. Is this an intended change in libvirt-0.8.7-11?

Comment 6 Dave Allan 2011-03-15 16:57:10 UTC
Dan, I don't believe that's intentional.  We do not change the units of the XML fields.  Assuming that's the case, it will be fixed along with https://bugzilla.redhat.com/show_bug.cgi?id=673578#c18 in -12.

Comment 7 Dan Kenigsberg 2011-03-15 17:20:29 UTC
(In reply to comment #6)
> Dan, I don't believe that's intentional.  We do not change the units of the XML
> fields.  Assuming that's the case, it will be fixed along with
> https://bugzilla.redhat.com/show_bug.cgi?id=673578#c18 in -12.

Cool. If vram= attribute is to be specified in KiB as it used to, there's nothing for vdsm to do here.

*** This bug has been marked as a duplicate of bug 673578 ***

Comment 8 Dave Allan 2011-03-17 01:38:45 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Dan, I don't believe that's intentional.  We do not change the units of the XML
> > fields.  Assuming that's the case, it will be fixed along with
> > https://bugzilla.redhat.com/show_bug.cgi?id=673578#c18 in -12.
> 
> Cool. If vram= attribute is to be specified in KiB as it used to, there's
> nothing for vdsm to do here.

Actually, the field *is* in KiB, and this bug is precisely a dup of 673578; qemu isn't barfing on the value (67108864 / 1024 = 65536, which is what was specified in the XML) it's barfing on the mangling of the field name, which is verified in -12 now and you should be good to go.

Comment 10 Dave Allan 2011-03-17 19:05:32 UTC
vram is documented as being in KiB at:

http://libvirt.org/formatdomain.html#elementsVideo


Note You need to log in before you can comment on or make changes to this bug.