Bug 687982 - Review Request: dvi2bitmap - convert DVI files to bitmaps
Summary: Review Request: dvi2bitmap - convert DVI files to bitmaps
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mohamed El Morabity
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-15 22:35 UTC by Jerry James
Modified: 2011-04-01 22:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-01 22:31:29 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jerry James 2011-03-15 22:35:44 UTC
Spec URL: http://jjames.fedorapeople.org/dvi2bitmap/dvi2bitmap.spec
SRPM URL: http://jjames.fedorapeople.org/dvi2bitmap/dvi2bitmap-0.13-1.fc14.src.rpm
Description:
dvi2bitmap is a utility to convert TeX DVI files directly to bitmaps, without
going through the complicated (and slow!) route of conversion via PostScript
and PNM.  The prime motivation for this is to prepare mathematical equations
for inclusion in HTML files, but there is a broad range of uses beyond that.

Comment 1 Mohamed El Morabity 2011-03-16 00:30:06 UTC
I will review this package.

Comment 2 Jerry James 2011-03-25 20:29:02 UTC
Mohamed, are you having difficulty with the review?  Is there something I can do to help?

Comment 3 Mohamed El Morabity 2011-03-29 00:53:04 UTC
Sorry for not being reactive, I got unfortunately very busy these last days. But I've never forgot this review :).

I've seen your patch reports on the SF page of dvi2bitmap. But I'm afraid you won't probably get any answer from the developers, since the project seems dead for 3 years at least :(. Moreover, no other Linux distribution I've checked seems to provide dvi2bitmap, so you'd be probably the only one to maintain this soft.
Anyway I won't close this review if you're still willing to maintain dvi2bitmap, even without upstream.

The package looks quite good in itself. I've quickly checked the patches, almost all of them look OK for me, except dvi2bitmap-init.patch: could you explain what was the issue fixed by swapping initializations?

Comment 4 Jerry James 2011-03-29 14:57:12 UTC
I am willing to maintain this package, even with a dead upstream.  I need it to produce documentation for another package, which is the one I *really* want in Fedora. :-)

The only point to swapping the initializations is to make g++ stop issuing warnings about the initializer order not matching the order of the fields in the class declaration.  I like warning-free builds, because then I notice if a new warning pops up.  That's all.  If you object, I'll drop that patch.

Comment 5 Mohamed El Morabity 2011-03-29 19:25:57 UTC
Ok for the patch :)

(In reply to comment #4)
> I am willing to maintain this package, even with a dead upstream.  I need it to
> produce documentation for another package, which is the one I *really* want in
> Fedora. :-)
Have you considered patching this other soft to use maybe dvipng instead of dvi2bitmap?
It's just a suggestion ^^

Comment 6 Jerry James 2011-03-29 20:22:43 UTC
Hmmmm, I will have to see how hard that is.  Give me a day or two to attempt that conversion before we proceed with this review.

Comment 7 Jerry James 2011-04-01 22:31:29 UTC
It's doable.  I'll modify the other project to use dvipng (and send the changes upstream) and drop this package.  Thanks, Mohamed.

Comment 8 Mohamed El Morabity 2011-04-01 22:45:51 UTC
Sorry for giving you more work than expected. I'll be glad to review your next package, if you want.


Note You need to log in before you can comment on or make changes to this bug.