Bug 688133 - qpid-route tool accepts bad input
Summary: qpid-route tool accepts bad input
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: qpid-qmf
Version: 1.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Ken Giusti
QA Contact: MRG Quality Engineering
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-16 12:34 UTC by Petr Matousek
Modified: 2012-12-10 22:37 UTC (History)
3 users (show)

Fixed In Version: qpid-tools-0.10-2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-10 22:37:37 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Petr Matousek 2011-03-16 12:34:57 UTC 
Description of problem:

In some cases the qpid-route tool accepts bad input.
No error is displayed, return code is equal to 0. 
No route is created (CORRECT).

Some examples:

# qpid-route x y
# echo $?
0
# qpid-route - - localhost
# echo $?
0
# qpid-route add x localhost y z
# echo $?
0
# qpid-route route list
#

This was seen on RHEL5.6 x86_64

Version-Release number of selected component (if applicable):
qpid-tools-0.9.1078967-1.el5

How reproducible:
100%

Steps to Reproduce:
1. 
2. 
3.

Actual results:
qpid-route tool behaves successfully even if bad input is supplied. return code is equal to 0.

Expected results:
Either an error message regarding the bad input or help shall be displayed or both. Return code shall be non-zero.

Additional info:
Comment 1 Gordon Sim 2011-04-01 11:20:00 UTC 
http://svn.apache.org/viewvc?rev=1085355&view=rev adds a usage statement and non-zero return code and as such addresses the basic concern here. This has been backported to 0-10 branch as well.
Comment 2 Ken Giusti 2011-04-08 20:03:13 UTC 
fix available in qpid-tools-0.10-2
Note You need to log in before you can comment on or make changes to this bug.