Bug 688218 - make rpm does not handle regexp metachars in test names
Summary: make rpm does not handle regexp metachars in test names
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: scheduler
Version: 0.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified vote
Target Milestone: ---
Assignee: Bill Peck
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-16 15:31 UTC by Petr Muller
Modified: 2019-05-22 13:38 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-07 03:39:36 UTC


Attachments (Terms of Use)

Comment 1 Dan Callaghan 2011-03-16 21:41:58 UTC
It is indeed the test name that is causing this problem. Specifically the + characters, which are regexp metachars.

Something like this should work:

--- a/bin/rhts-mk-get-current-tag
+++ b/bin/rhts-mk-get-current-tag
@@ -29,7 +29,7 @@ PACKAGE_NAME=`rhts-mk-get-test-package-name`
 
 # for CVS, find the tag with the package name
 if [ -d "CVS" ]; then
-       CURRENT_TAG=`cvs -Q status -lv | grep -v '^?' | grep -E "${PACKAGE_NAME}-([0-9_\-]+)" | head -n 1  | awk '{print $1}'`
+       CURRENT_TAG=`cvs -Q status -lv | grep -v '^?' | grep -F "${PACKAGE_NAME}" | head -n 1  | awk '{print $1}'`
 fi
 
 # for svn, just use the svn repo revision number for the package revision number

Comment 2 Bill Peck 2011-03-23 18:12:31 UTC
dan's change has been pushed to gerrit for review.


Note You need to log in before you can comment on or make changes to this bug.