Bug 688993 - Make comparisons to None (singleton) done with 'is' and 'is not'
Summary: Make comparisons to None (singleton) done with 'is' and 'is not'
Status: CLOSED DEFERRED
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virtinst
Version: unspecified
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-18 18:22 UTC by Satoru SATOH
Modified: 2012-01-25 01:35 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2012-01-25 01:35:43 UTC


Attachments (Terms of Use)

Description Satoru SATOH 2011-03-18 18:22:33 UTC
Description of problem: This is a trivial patch to make comparisons to
None done with 'is'/'is not' instead of '=='/'!=' on the advice in
pep8 (http://www.python.org/dev/peps/pep-0008/):

   - Comparisons to singletons like None should always be done with
     'is' or 'is not', never the equality operators.

Version-Release number of selected component (if applicable):
I made a pathc for git HEAD but I guess it should be applicable to 
the versions of python-virtinst in fedora-14/15.

Comment 1 Cole Robinson 2011-03-21 15:53:35 UTC
Moved to upstream virtinst tracker. I'd be interested in seeing the patch

Comment 2 Cole Robinson 2012-01-25 01:35:43 UTC
Closing since no patch provided and not really something that needs tracking in bugzilla.


Note You need to log in before you can comment on or make changes to this bug.