Bug 689212 - Review Request: hunspell-tpi - Tok Pisin hunspell dictionaries
Summary: Review Request: hunspell-tpi - Tok Pisin hunspell dictionaries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mario Blättermann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-20 11:31 UTC by Caolan McNamara
Modified: 2011-05-25 07:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-25 07:50:15 UTC
Type: ---
Embargoed:
mario.blaettermann: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2011-03-20 11:31:33 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hunspell-tpi.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hunspell-tpi-0.05-1.fc15.src.rpm
Description: Tok Pisin hunspell dictionaries

Comment 1 Mario Blättermann 2011-05-08 16:18:36 UTC
$ rpmlint -v *
hunspell-tpi.noarch: I: checking
hunspell-tpi.noarch: W: spelling-error Summary(en_US) Tok -> Tod, Tom, Tob
hunspell-tpi.noarch: W: spelling-error %description -l en_US Tok -> Tod, Tom, Tob
hunspell-tpi.noarch: I: checking-url http://extensions.services.openoffice.org/en/project/tok-pisin-spell-checker (timeout 10 seconds)
hunspell-tpi.noarch: W: invalid-url URL: http://extensions.services.openoffice.org/en/project/tok-pisin-spell-checker <urlopen error [Errno 104] Connection reset by peer>
hunspell-tpi.src: I: checking
hunspell-tpi.src: W: spelling-error Summary(en_US) Tok -> Tod, Tom, Tob
hunspell-tpi.src: W: spelling-error %description -l en_US Tok -> Tod, Tom, Tob
hunspell-tpi.src: I: checking-url http://extensions.services.openoffice.org/en/project/tok-pisin-spell-checker (timeout 10 seconds)
hunspell-tpi.src: I: checking-url http://extensions.services.openoffice.org/e-files/4824/2/hunspell-tpi-0.05.oxt (timeout 10 seconds)
hunspell-tpi.spec: I: checking-url http://extensions.services.openoffice.org/e-files/4824/2/hunspell-tpi-0.05.oxt (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 5 warnings.

No issues so far. At least nothing we should be aware of. The spelling error could be ignored.

Koji scratch build for f15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058321

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPLv3+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    39619bd8a95265e9501e1c438ea1d290  hunspell-tpi-0.05.oxt
    39619bd8a95265e9501e1c438ea1d290  hunspell-tpi-0.05.oxt.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[.] MUST: All build dependencies must be listed in BuildRequires.
    No BuildRequires at all.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
    I assume the packager has tested it.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.

----------------

PACKAGE APPROVED

----------------

Comment 2 Caolan McNamara 2011-05-24 10:35:20 UTC
New Package SCM Request
=======================
Package Name: hunspell-tpi
Short Description: Tok Pisin hunspell dictionaries
Owners: caolanm
Branches: f15, devel

Comment 3 Jason Tibbitts 2011-05-24 14:44:53 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.