Bug 689329 - livecd-iso-to-disk installs syslinux files in root directory
Summary: livecd-iso-to-disk installs syslinux files in root directory
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-21 06:39 UTC by Frederick Grose
Modified: 2011-08-11 23:21 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-11 23:21:16 UTC
Type: ---

Attachments (Terms of Use)
Fix pipefailure in checkSyslinuxVersion() (1.16 KB, application/octet-stream)
2011-03-21 06:39 UTC, Frederick Grose 		no flags Details
Really fix pipefailure in checkSyslinuxVersion() (1.14 KB, patch)
2011-03-21 07:11 UTC, Frederick Grose 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Frederick Grose 2011-03-21 06:39:58 UTC 
Created attachment 486546 [details]
Fix pipefailure in checkSyslinuxVersion()

The new set -o pipefail option, set early, changes a return value in checkSyslinuxVersion() leading to SYSLINUXPATH being set to "".

The attached patch rewrites the test. The earlier test tested the usage function in /usr/bin/syslinux.

The replacement checks the the --version output for a general 'syslinux' response.

This should exercise the installed program like the previous test, but I'm not familiar with the use case for the failure condition that leads to SYSLINUXPATH being set to "".
Comment 1 Frederick Grose 2011-03-21 07:11:59 UTC 
Created attachment 486551 [details]
Really fix pipefailure in checkSyslinuxVersion()

Resubmitted patch with test operation changed from == to != as required.
Note You need to log in before you can comment on or make changes to this bug.