Bug 690726 - Review Request: python-hg-git - mercurial client to talk to git server
Summary: Review Request: python-hg-git - mercurial client to talk to git server
Keywords:
Status: CLOSED DUPLICATE of bug 969812
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John F
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-25 07:21 UTC by John F
Modified: 2014-11-17 14:33 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-06 02:27:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John F 2011-03-25 07:21:42 UTC
Spec URL: http://people.mozilla.com/~jford/fedora/hg-git.spec
SRPM URL: http://people.mozilla.com/~jford/fedora/python-hg-git-0.2.6-1.fc14.src.rpm
Description: (not sure if this should be upstream's description or mine, upstream's is in the spec)

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2944506

This is a mercurial extension that allows someone to use mercurial to interact with git servers.  It is a fairly simple package but I had a question regarding naming.

The upstream project is called 'hg-git' but the module is 'hggit'.  according to the naming guidelines [1], I think i should use hggit (more specifically python-hggit).  Is this correct?


[1]https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29

Comment 1 John F 2011-03-25 18:54:56 UTC
Thanks, thm.  I have modified the spec to use the python-hggit name as well as running tests as a part of the build.  

SPEC URL: http://people.mozilla.com/~jford/fedora/python-hggit.spec
SRPM URL: http://people.mozilla.com/~jford/fedora/python-hggit-0.2.6-1.fc14.src.rpm

scratch koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2946182

Comment 2 W. Michael Petullo 2011-10-28 01:16:28 UTC
I tried to build this package but received:

[...]
-% expect 'git'
-git
-% expect '/webjam/webjam.git'
-/webjam/webjam.git
-% expect 'github.com'
-github.com
+Traceback (most recent call last):
+  File "/home/mike/Source/rpms/BUILD/hg-git-0.2.6/tests/test-url-parsing.py", line 6, in <module>
+    from hggit.git_handler import GitHandler
+  File "/home/mike/Source/rpms/BUILDROOT/python-hggit-0.2.6-1.fc15.x86_64/usr/lib/python2.7/site-packages/hggit/__init__.py", line 134, in <module>
+    extensions.wrapfunction(discovery, 'findoutgoing', findoutgoing)
+  File "/usr/lib64/python2.7/site-packages/mercurial/extensions.py", line 184, in wrapfunction
+    origfn = getattr(container, funcname)
+AttributeError: 'module' object has no attribute 'findoutgoing'

Failed test-empty-working-tree: output changed and returned error code 1
Failed test-push-r: output changed and returned error code 1
Failed test-url-parsing.py: output changed and returned error code 1
# Tested unexpected mercurial: None
# Ran 20 tests, 17 skipped, 3 failed.
# Cleaning up HGTMP /tmp/hgtests.TcaV1E
error: Bad exit status from /tmp/rpm-tmp.2Lrf4h (%check)


RPM build errors:
    user jhford does not exist - using root
    group jhford does not exist - using root
    user jhford does not exist - using root
    group jhford does not exist - using root
    Bad exit status from /tmp/rpm-tmp.2Lrf4h (%check)

Comment 3 Ed Marshall 2012-01-31 19:54:01 UTC
Updating to the latest version of hg-git (0.3.2 as of this posting) resolves the problem and allows this to build (the discovery API changed in Mercurial 1.9, and findoutgoing is no longer available).

Also, Source0 could be changed to http://pypi.python.org/packages/source/h/%{srcname}/%{srcname}-%{version}.tar.gz (upstream doesn't provide tarballs directly from their website, but they do make them available in pypi). The downside is, the version shipped via pypi doesn't include the tests directory, so perhaps grabbing the tagged releases from bitbucket are still a better idea (the list of tags on github doesn't seem to be up-to-date).

John, would you be willing to post an updated version?

Comment 4 Hin-Tak Leung 2012-07-09 03:50:49 UTC
most of the urls have disappeared.

Comment 5 Christopher Meng 2013-06-06 02:27:31 UTC

*** This bug has been marked as a duplicate of bug 969812 ***


Note You need to log in before you can comment on or make changes to this bug.