Bug 690750 - virt-install: 'io=native' should not be automatically attached to cdrom device
Summary: virt-install: 'io=native' should not be automatically attached to cdrom device
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: python-virtinst
Version: 6.1
Hardware: Unspecified
OS: Linux
medium
low
Target Milestone: rc
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-25 10:16 UTC by Nan Zhang
Modified: 2011-12-06 16:16 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
No description necessary
Clone Of:
Environment:
Last Closed: 2011-12-06 16:16:16 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1643 0 normal SHIPPED_LIVE python-virtinst bug fix and enhancement update 2011-12-06 00:50:36 UTC

Description Nan Zhang 2011-03-25 10:16:35 UTC
Description of problem:
'io=threads' should not be automatically attached to cdrom device if doesn't set this attribute when installing.

Version-Release number of selected component (if applicable):
libvirt-0.8.7-14.el6.x86_64
python-virtinst-0.500.5-2.el6.noarch

How reproducible:
Always

Steps to Reproduce:
# virt-install -n demo -r 512 --disk path=/var/lib/libvirt/images/demo.img,size=6,io=threads -c /var/lib/libvirt/boot/Fedora-14-i686-Live-Desktop.iso --vnc

# virsh dumpxml demo

Actual results:
(...)
    <disk type='file' device='cdrom'>
      <driver name='qemu' type='raw' io='threads'/>
      <source file='/var/lib/libvirt/boot/Fedora-14-i686-Live-Desktop.iso'/>
      <target dev='hdc' bus='ide'/>
      <readonly/>
      <address type='drive' controller='0' bus='1' unit='0'/>
    </disk>
(...)

Expected results:
(...)
    <disk type='file' device='cdrom'>
      <driver name='qemu' type='raw'/>
      <source dev='/var/lib/libvirt/boot/Fedora-14-i686-Live-Desktop.iso'/>
      <target dev='hdc' bus='ide'/>
      <readonly/>
      <address type='drive' controller='0' bus='1' unit='0'/>
    </disk>
(...)

Additional info:

Comment 1 RHEL Program Management 2011-04-04 02:14:55 UTC
Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 2 Cole Robinson 2011-04-07 16:24:37 UTC
Hmm, is there a reason why? Does it cause issues or just not preferred performance? In my limited testing the cdrom still works at least.

Dor, any reason not to use io=threads for CDROM? If so, any other caveats?

Comment 3 Cole Robinson 2011-06-10 20:01:41 UTC
Can someone provide the info requested in comment #2? Dor maybe?

Comment 5 Cole Robinson 2011-07-18 14:40:42 UTC
I talked with kwolf on IRC. Basically virtinst/virt-manager shouldn't be hardcoding io=threads at all, since that is the qemu default mode. I've filed a bug about this:

https://bugzilla.redhat.com/show_bug.cgi?id=722938

Once we fix that default, and start using aio=native, we want to make sure we don't specify that value for removable media devices, to save ourselves the pain of needing to tweak the aio value when media changes.

Comment 6 Cole Robinson 2011-07-21 21:48:21 UTC
Defaults are tracked upstream now with a --rhel6defaults build time switch:

http://git.fedorahosted.org/git?p=python-virtinst.git;a=commit;h=0075dd8730adaf8aa3d7f90655d0626374fdd5b4

Just need to turn that on when we rebase

Comment 7 Cole Robinson 2011-07-28 15:34:43 UTC
Fixed in python-virtinst-0.600.0-1.el6

Comment 9 zhe peng 2011-08-01 07:56:10 UTC
Verify with:

python-virtinst-0.600.0-1.el6
libvirt-0.9.4-0rc1.el6
qemu-kvm-0.12.1.2-2.172.el6

#virt-install -n test -r 1024 --disk path=/tmp/test.img,size=6 -c /tmp/RHEL6.1-20110510.1-Server-x86_64-DVD1.iso  --vnc
#virsh dumpxml test
...
 <disk type='file' device='cdrom'>
      <driver name='qemu' type='raw'/>
      <source file='/tmp/RHEL6.1-20110510.1-Server-x86_64-DVD1.iso'/>
      <target dev='hdc' bus='ide'/>
      <readonly/>
      <alias name='ide0-1-0'/>
      <address type='drive' controller='0' bus='1' unit='0'/>
    </disk>
...

#ps -ef|grep kvm

qemu     30382     1 23 03:06 ?        00:00:00 /usr/libexec/qemu-kvm -S -M rhel6.2.0 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name test -uuid 0a319d45-eb69-3485-7fa0-3abf4ca4f09f -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/test.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-reboot -no-shutdown -drive file=/tmp/test.img,if=none,id=drive-ide0-0-0,format=raw,cache=none -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=2 -drive file=/tmp/RHEL6.1-20110510.1-Server-x86_64-DVD1.iso,if=none,media=cdrom,id=drive-ide0-1-0,readonly=on,format=raw -device ide-drive,bus=ide.1,unit=0,drive=drive-ide0-1-0,id=ide0-1-0,bootindex=1 -netdev tap,fd=28,id=hostnet0 -device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:c7:63:15,bus=pci.0,addr=0x3 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -usb -vnc 127.0.0.1:1 -vga cirrus -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x4

verification passed.

Comment 10 Cole Robinson 2011-11-07 16:51:45 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No description necessary

Comment 11 errata-xmlrpc 2011-12-06 16:16:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1643.html


Note You need to log in before you can comment on or make changes to this bug.