Bug 692808 - [Regression 6.1 Alpha] Config isn't persisted even if click "yes" when hot adding an IDE disk.
Summary: [Regression 6.1 Alpha] Config isn't persisted even if click "yes" when hot a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: virt-manager
Version: 6.1
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-01 09:21 UTC by Mark Wu
Modified: 2018-11-14 13:48 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 13:48:03 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0637 0 normal SHIPPED_LIVE virt-manager bug fix and enhancement update 2011-05-18 17:55:47 UTC

Description Mark Wu 2011-04-01 09:21:36 UTC
Description of problem:
When I try to add an IDE disk to a running vm, I get the following warning:
"This device could not be attached to the running machine. Would you like to make the device available after the next VM shutdown?"
And then I click "yes", but it's not added to the VM after shutdown or reboot. 

After changing back to "yes_no", it works fine:
<snip>
            if attach_err:
#            res = self.err.show_err(
            res = self.err.yes_no(
                _("Are you sure you want to add this device?"),
#                attach_err[0] + "\n\n" + attach_err[1],
                text2=(
                _("This device could not be attached to the running machine. "
                  "Would you like to make the device available after the "
                  "next VM shutdown?")))
#                dialog_type=gtk.MESSAGE_WARNING,
#                buttons=gtk.BUTTONS_YES_NO)
</snip>
So I suppose the problem existing in show_err.

Version-Release number of selected component (if applicable):
virt-manager-0.8.6-1.el6.noarch
and virt-manager-0.8.6-3.el6.noarch also has this problem.
But virt-manager-0.8.4-8.el6 can works fine. 

How reproducible:
100%

Steps to Reproduce:
1. Add an IDE disk to a running VM
2. Click the button "yes" in the warning dialogue 
3. Shutdown the VM
  
Actual results:
The IDE disk is not added

Expected results:
The IDE disk should be added

Additional info:

Comment 2 Cole Robinson 2011-04-07 17:06:57 UTC
Thanks for the report, this is indeed a regression, fixed upstream now:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=4922222c2c7b13704b6f461aedbee9ec06c01b5b

Comment 6 Cole Robinson 2011-04-19 17:09:53 UTC
Fixed in virt-manager-0.8.6-4

Comment 8 mliu 2011-04-20 05:17:17 UTC
Verified it, Passed on virt-manager-0.8.6-4

#uname -a
Linux rhel6u1 2.6.32-131.0.1.el6.x86_64 #1 SMP Tue Apr 12 16:40:23 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux

virt-manager-0.8.6-4.el6.noarch
libvirt-0.8.7-18.el6.x86_64
qemu-kvm-0.12.1.2-2.158.el6.x86_64

Steps:
1. Add an IDE disk to a running VM
2. Click the button "yes" in the warning dialogue 
3. Shutdown the VM
4. The IDE disk is added.
5. Run the VM again
6. Add an IDE disk to a running VM
7. Click the button "no" in the warning dialogue 
8. Shutdown the VM
9. The IDE disk is not added.
And for IDE cdrom, Floppy disk are all work well.

Comment 9 errata-xmlrpc 2011-05-19 13:48:03 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0637.html


Note You need to log in before you can comment on or make changes to this bug.