Bug 695055 - variable 'exitting' is never used
Summary: variable 'exitting' is never used
Keywords:
Status: CLOSED DUPLICATE of bug 639429
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: device-mapper-multipath
Version: 5.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: LVM and device-mapper development team
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 639429
TreeView+ depends on / blocked
 
Reported: 2011-04-10 08:39 UTC by Kamil Dudka
Modified: 2011-04-11 16:58 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-11 16:58:33 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Kamil Dudka 2011-04-10 08:39:05 UTC
Description of problem:
device-mapper-multipath-0.4.7-44.el5 adds a new variable 'exitting', which is never used.


Version-Release number of selected component (if applicable):
device-mapper-multipath-0.4.7-44.el5


Actual results:
Error: STRAY_SEMICOLON:
multipath-tools-0.4.7.rhel5.30/multipathd/main.c:1508: stray_semicolon: "if" statement "if (!exitting /* != 0 */);" with no "then" or "else" is suspicious.


Additional info:
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1505,7 +1505,7 @@ sighup (int sig)
        condlog(2, "reconfigure (SIGHUP)");

        lock(gvecs->lock);
-       if (!exitting);
+       if (!exitting)
                reconfigure(gvecs);
        unlock(gvecs->lock);

Comment 1 Kamil Dudka 2011-04-10 08:41:25 UTC
(In reply to comment #0)
> Version-Release number of selected component (if applicable):
> device-mapper-multipath-0.4.7-44.el5

The bug is also present in device-mapper-multipath-0.4.7-45.el5.

Comment 2 Ben Marzinski 2011-04-11 16:58:33 UTC
Since that change hasn't made it through QA yet, I'm just going to dup this to the bug that originally made the change and fix it there.

*** This bug has been marked as a duplicate of bug 639429 ***


Note You need to log in before you can comment on or make changes to this bug.