Description of problem:
device-mapper-multipath-0.4.7-44.el5 adds a new variable 'exitting', which is never used.
Version-Release number of selected component (if applicable):
device-mapper-multipath-0.4.7-44.el5
Actual results:
Error: STRAY_SEMICOLON:
multipath-tools-0.4.7.rhel5.30/multipathd/main.c:1508: stray_semicolon: "if" statement "if (!exitting /* != 0 */);" with no "then" or "else" is suspicious.
Additional info:
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1505,7 +1505,7 @@ sighup (int sig)
condlog(2, "reconfigure (SIGHUP)");
lock(gvecs->lock);
- if (!exitting);
+ if (!exitting)
reconfigure(gvecs);
unlock(gvecs->lock);
(In reply to comment #0)
> Version-Release number of selected component (if applicable):
> device-mapper-multipath-0.4.7-44.el5
The bug is also present in device-mapper-multipath-0.4.7-45.el5.
Since that change hasn't made it through QA yet, I'm just going to dup this to the bug that originally made the change and fix it there.
*** This bug has been marked as a duplicate of bug 639429 ***
Description of problem: device-mapper-multipath-0.4.7-44.el5 adds a new variable 'exitting', which is never used. Version-Release number of selected component (if applicable): device-mapper-multipath-0.4.7-44.el5 Actual results: Error: STRAY_SEMICOLON: multipath-tools-0.4.7.rhel5.30/multipathd/main.c:1508: stray_semicolon: "if" statement "if (!exitting /* != 0 */);" with no "then" or "else" is suspicious. Additional info: --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1505,7 +1505,7 @@ sighup (int sig) condlog(2, "reconfigure (SIGHUP)"); lock(gvecs->lock); - if (!exitting); + if (!exitting) reconfigure(gvecs); unlock(gvecs->lock);