Hide Forgot
Spec URL: http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-commons.spec SRPM URL: http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-commons-3.5.0-1.fc15.src.rpm Description: Mylyn integrates task support into Eclipse. It supports offline editing for certain task repositories and monitors work activity to hide information that is not relevant to the current task. This package includes common libraries used by other Eclipse Mylyn packages. Eclipse Mylyn became a new top-level project at eclipse.org. The new Mylyn release 3.5.0 includes about 20 features and 8 different sub-projects. This is the first part of the 8 sub-projects.
I'll do this now.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: eclipse-mylyn-commons.noarch: W: no-documentation You have to add org.eclipse.mylyn.commons/org.eclipse.mylyn.commons-feature/epl-v10.html as %doc eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/jaxmeapi.jar /usr/share/java/jaxme/jaxmeapi.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/json.jar /usr/share/java/json.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/apache-commons-io.jar /usr/share/java/apache-commons-io.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/apache-commons-logging-api.jar /usr/share/java/apache-commons-logging-api.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/xmlrpc3-common.jar /usr/share/java/xmlrpc3-common.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/jdom.jar /usr/share/java/jdom.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/ws-commons-util.jar /usr/share/java/ws-commons-util.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/xmlrpc3-client.jar /usr/share/java/xmlrpc3-client.jar eclipse-mylyn-commons.noarch: W: dangling-symlink /usr/share/eclipse/dropins/mylyn-commons/eclipse/plugins/apache-commons-lang.jar /usr/share/java/apache-commons-lang.jar Not a problem. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: EPL [!] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [-] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [!] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [!] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [-] Javadoc documentation files are generated and included in -javadoc subpackage [-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [-] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [-] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [-] If package contains pom.xml files install it (including depmaps) even when building with ant [-] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly) === Issues === 1. Install epl file as %doc. 2. Remove %clean section and cleaning of buildroot from beginning of %install 3. Use %{buildroot} and $RPM_BUILD_ROOT consistently. 4. Are you sure that you need to BR eclipse-cdt? It is not put on the pdebuild path so it should not be needed. 5. Why do you replace qualifier manually in %prep? Isn't it done by pdebuild automatically?
Thanks for the review. (In reply to comment #2) > === Issues === > 1. Install epl file as %doc. > 2. Remove %clean section and cleaning of buildroot from beginning of %install > 3. Use %{buildroot} and $RPM_BUILD_ROOT consistently. All fixed. > 4. Are you sure that you need to BR eclipse-cdt? It is not put on the pdebuild > path so it should not be needed. Isn't needed. Fixed. > 5. Why do you replace qualifier manually in %prep? Isn't it done by pdebuild > automatically? Good point. Doesn't seem to be needed. Let me know if there are other issues.
Spec-file and SRPM updated as linked above.
All good. Only issue is when you do changes you should add a changelog entry and bump the release. APPROVED.
(In reply to comment #5) > All good. Only issue is when you do changes you should add a changelog entry > and bump the release. Noted. Thanks!
New Package SCM Request ======================= Package Name: eclipse-mylyn-commons Short Description: Eclipse Mylyn common libraries/plug-ins. Owners: jerboaa akurtakov Branches: f15 InitialCC: overholt
Git done (by process-git-requests).