Bug 696792 - add check to glpk
Summary: add check to glpk
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: glpk
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Conrad Meyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-14 20:19 UTC by Jorn Amundsen
Modified: 2011-10-28 05:20 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-28 05:20:31 UTC
Type: ---


Attachments (Terms of Use)
glpk-doc-4.45 listing with the proposed change (5.84 KB, text/plain)
2011-04-14 20:27 UTC, Jorn Amundsen
no flags Details

Description Jorn Amundsen 2011-04-14 20:19:41 UTC
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.16) Gecko/20110322 Fedora/3.6.16-1.fc13 Firefox/3.6.16

The glpk application does provide a check Makefile tag. Hence a %check tag should be added to the spec file. Th provide this, the last 2 lines of the 9 Feb 2011 f15/master spec file must be removed or moved into make check. Suggestion:

REMOVE
  ## Clean up directories that are included in docs
! make clean
! rm -Rf examples/.deps examples/Makefile* doc/*.dvi doc/*.latex

ADD
! %check
! make check
  ## Clean up directories that are included in docs
! rm -Rf examples/{.deps,.libs,Makefile*,glpsol,glpsol.o} doc/*.tex

Note the doc/*.tex vs. doc/*.latex. There are no .latex files.



Reproducible: Always

Comment 1 Jorn Amundsen 2011-04-14 20:27:28 UTC
Created attachment 492219 [details]
glpk-doc-4.45 listing with the proposed change

The attachment provides the output of rpm -qlp glpk-doc-4.45 after applying the proposed change.

Comment 2 Conrad Meyer 2011-04-25 00:41:40 UTC
I've done this in 726ec18289996f6f2bbe1c87e333078b0da66417 ; however, I can't seem to build it on Koji ("Opening a SSL connection failed") and locally it seems to have developed a bad rpath linking glpsol. So, I don't know what's going on.

Comment 3 Conrad Meyer 2011-10-28 05:20:31 UTC
Got my koji setup working; here's the build in rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3467641

I'm going to bump rawhide to the latest glpk soon, however. I'll do a build of 
the F-16 %check section as soon as this completes.


Note You need to log in before you can comment on or make changes to this bug.