Bug 697067 - From virt-manager: Warning: comparing different enum types: VncConnectionCredential and VncDisplayCredential
Summary: From virt-manager: Warning: comparing different enum types: VncConnectionCred...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gtk-vnc
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-15 18:05 UTC by Cole Robinson
Modified: 2013-03-04 22:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-04 22:23:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Cole Robinson 2011-04-15 18:05:15 UTC
In virt-manager we've got code like this

        self.display.connect("vnc-auth-credential", self._auth_credential)

    def _auth_credential(self, src_ignore, credList):
        for cred in credList:
            if cred in [gtkvnc.CREDENTIAL_PASSWORD,
                        gtkvnc.CREDENTIAL_USERNAME,
                        gtkvnc.CREDENTIAL_CLIENTNAME]:

Which throws a warning to stderr:

/home/nishome/crobinso/sandbox/upstream/virt-manager/virt-manager.git/src/virtManager/console.py:294: Warning: comparing different enum types: VncConnectionCredential and VncDisplayCredential
  gtkvnc.CREDENTIAL_CLIENTNAME]:

however the code works and continues on fine. Truthfully not really sure if we are doing something incorrect in virt-manager, but from poking at the gtkvnc python API I can't really find any other constants to compare against.

This doesn't really need to be fixed for fedora, just something wanted it to be tracked somewhere.

Comment 1 Daniel Berrangé 2011-04-18 12:53:59 UTC
This is almost certainly a gtk-vnc bug. The VncDisplay object shouldn't be leaking enum values from VncConnection, instead it has its own set of enums. Fortunately the actual enum values are currently the same so you won't get ill effects from this mis-match

Comment 2 Cole Robinson 2012-06-06 17:53:42 UTC
Pretty sure this is still relevant as of at least F16

Comment 3 Fedora End Of Life 2013-01-16 11:56:07 UTC
This message is a reminder that Fedora 16 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 16. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '16'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 16's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 16 is end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" and open it against that version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Cole Robinson 2013-02-11 21:12:12 UTC
Still relevant on F18

Comment 5 Daniel Berrangé 2013-02-22 11:25:07 UTC
commit 5a33bad94724b85fbf237dd94806ea589339c64b
Author: Daniel P. Berrange <berrange>
Date:   Fri Feb 22 11:24:09 2013 +0000

    Convert VncConnectionCredential to VncDisplayCredential
    
    When forwarding the auth signal from VncConnection to consumers
    of VncDisplay, the VncConnectionCredential enums must be turned
    into VncDisplayCredential enums
    
    Signed-off-by: Daniel P. Berrange <berrange>

Comment 6 Fedora Update System 2013-02-22 13:44:34 UTC
gtk-vnc-0.5.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gtk-vnc-0.5.2-1.fc18

Comment 7 Fedora Update System 2013-02-24 08:59:35 UTC
Package gtk-vnc-0.5.2-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gtk-vnc-0.5.2-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-2991/gtk-vnc-0.5.2-1.fc18
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-03-04 22:23:19 UTC
gtk-vnc-0.5.2-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.