Spec URL: http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-tasks.spec SRPM URL: http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-tasks-3.5.0-1.fc15.src.rpm Description: Mylyn Bugzilla/Trac Tasks Connectors This source RPM depends on eclipse-mylyn, eclipse-mylyn-commons and eclipse-mylyn-context. To make it easier for the reviewer, I'm providing binary RPMs for them here: http://fedorapeople.org/~jerboaa/rpm/mylyn/bin-rpms/ If someone prefers SRPMs, they can be found here: http://fedorapeople.org/~jerboaa/rpm/mylyn/ Thanks for reviewing :)
And this one is mine :)
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: eclipse-mylyn-tasks-bugzilla.noarch: W: self-obsoletion eclipse-bugzilla < 1:0.2.5 obsoletes eclipse-bugzilla = 1:0.2.4-4.fc6 Hmm, fc6? Just drop this provides/obsoletes. Btw, do the same for all eclipse-mylar provides/obsoletes, they have stayed long enough. eclipse-mylyn-tasks-bugzilla.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/share/eclipse/dropins/mylyn-bugzilla/redhat-bugzilla-custom-transitions.txt eclipse-mylyn-tasks-bugzilla.noarch: W: conffile-without-noreplace-flag /usr/share/eclipse/dropins/mylyn-bugzilla/redhat-bugzilla-custom-transitions.txt Please drop the conffile, we dont' want people to start editing the file, do we? [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: EPL [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [-] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [-] Javadoc documentation files are generated and included in -javadoc subpackage [-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [-] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [-] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [-] If package contains pom.xml files install it (including depmaps) even when building with ant [-] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly) === Issues === 1. Drop obsoletes/provides for eclipse-bugzilla, eclipse-mylar-* packages. 2. remove rm -rf %{buildroot} from beginning of install section 3. Drop the conffile marker forthe redhat bugzilla file 4. redhat-bugzilla-custom-transitions.txt.patch should be a regular file, kept as source and installed directly 5. url should be changed to http://eclipse.org/mylyn/tasks/ to be more accurate.
(In reply to comment #2) > === Issues === > 1. Drop obsoletes/provides for eclipse-bugzilla, eclipse-mylar-* packages. > 2. remove rm -rf %{buildroot} from beginning of install section > 3. Drop the conffile marker forthe redhat bugzilla file > 4. redhat-bugzilla-custom-transitions.txt.patch should be a regular file, kept > as source and installed directly > 5. url should be changed to http://eclipse.org/mylyn/tasks/ to be more accurate. Should be fixed now. Updated SRPM: http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-tasks-3.5.0-2.fc15.src.rpm Spec file: http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-tasks.spec Thanks!
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: eclipse-mylyn-tasks Short Description: Mylyn Bugzilla/Trac Tasks Connectors Owners: jerboaa akurtakov Branches: f15 InitialCC: overholt
Git done (by process-git-requests).