Description of problem:

  Warnings are generated for the conductor classads plugin when compiling git head (both master and next branches):

    warning: unused variable 'error'
    warning: unknown conversion type character 0xa in format
    warning: too many arguments for format

  It's non-fatal, in that aeolus-all does build, but from a quality point of view it would be nice to get rid of these.


How reproducible:

  Every time.


Steps to Reproduce:
  1. $ sudo yum install classads-devel rest-devel
  2. $ git clone git://git.fedorahosted.org/git/aeolus/conductor.git -b next
  3. $ cd conductor; ./autogen.sh
  4. $ make rpms

  The warnings are in the output from the make rpms command.

Actual results:

Making all in src/classad_plugin
make[3]: Entering directory `/home/jc/rpmbuild/BUILD/aeolus-conductor-0.0.3/src/classad_plugin'
/bin/sh ../../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../..  -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -pthread -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include    -I/usr/include/libxml2   -pthread -I/usr/include/rest-0.6 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libsoup-2.4 -I/usr/include/libxml2   -DLOGFILE=\"/var/log/condor/conductor_condor_plugin.log\"   -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o conductor_classad_plugin.lo conductor_classad_plugin.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -pthread -I/usr/include/rest-0.6 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -DLOGFILE=\"/var/log/condor/conductor_condor_plugin.log\" -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c conductor_classad_plugin.cpp  -fPIC -DPIC -o .libs/conductor_classad_plugin.o
In file included from /usr/lib/gcc/x86_64-redhat-linux/4.5.1/../../../../include/c++/4.5.1/ext/hash_map:60:0,
                 from /usr/include/classad/classad_stl.h:30,
                 from /usr/include/classad/classad.h:28,
                 from /usr/include/classad/classad_distribution.h:25,
                 from conductor_classad_plugin.cpp:6:
/usr/lib/gcc/x86_64-redhat-linux/4.5.1/../../../../include/c++/4.5.1/backward/backward_warning.h:28:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated.
conductor_classad_plugin.cpp: In function 'RestXmlNode* get_xml(RestProxyCall*)':
conductor_classad_plugin.cpp:80:11: warning: unused variable 'error'
conductor_classad_plugin.cpp: In function 'bool conductor_quota_check(const char*, const ArgumentList&, EvalState&, Value&)':
conductor_classad_plugin.cpp:131:67: warning: unknown conversion type character 0xa in format
conductor_classad_plugin.cpp:131:67: warning: too many arguments for format