Bug 70024 - Incorrect path to OpennSSL includes
Summary: Incorrect path to OpennSSL includes
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Raw Hide
Classification: Retired
Component: pwlib
Version: 1.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Larsson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 67217
TreeView+ depends on / blocked
 
Reported: 2002-07-29 09:27 UTC by Alec Voropay
Modified: 2008-05-01 15:38 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2002-07-30 03:52:11 UTC


Attachments (Terms of Use)

Description Alec Voropay 2002-07-29 09:27:32 UTC
Description of Problem:
The
/usr/share/pwlib/make/unix.mak
produces incorrect path to OpenSSL include directory
even the OPENSSLDIR=/usr/unclude/openssl defined

============
unix.mak
1234:STDCCFLAGS += -DP_SSL -I$(OPENSSLDIR)/include -I$(OPENSSLDIR)/crypto
============
It produces :
... -I/usr/include/openssl/include -I/usr/include/openssl/crypto


Version-Release number of selected component (if applicable):
pwlib-devel-1.3.3-2
pwlib-1.3.3-2


How Reproducible:
Try to compile any "pwlib" app

Steps to Reproduce:
1. export PWLIBDIR=/usr/share/pwlib
2. export OPENSSLDIR=/usr/include/openssl
3. make opt

Actual Results:
g++ -Wall -DP_LINUX -mcpu=i686 -D_REENTRANT -DP_HAS_SEMAPHORES -DP_SSL -I/usr/in
clude/openssl/include -I/usr/include/openssl/crypto -DP_EXPAT -DP_PTHREADS -DPHA
S_TEMPLATES -DPBYTE_ORDER=PLITTLE_ENDIAN -I/usr/share/pwlib/include/ptlib/unix -
I/usr/share/pwlib/include -O3 -DNDEBUG  -c a.cxx -o obj_linux_x86_r/a.o


Expected Results:
-I /usr/include/openssl

Additional Information:
1) pwlib-devel should depend on openssl-devel

2) pwlib-devel should export:

PWLIBDIR=/usr/share/pwlib
OPENSSLDIR=/usr/include/openssl
in
/etc/profile.d/pwlib.sh

Comment 1 Alexander Larsson 2002-08-07 10:03:22 UTC
Sounds like broken code to me, openssl is typically included like this:
#include <openssl/ssl.h>
So no -I is needed.

In fact adding an -I/usr/include/openssl fills up the includefile namespace with
all sort of dangerous filenames that can collide with other ones in libs and apps.



Note You need to log in before you can comment on or make changes to this bug.