Bug 700832 - Review Request: liblogging - An easy to use, portable, open source library for system logging
Summary: Review Request: liblogging - An easy to use, portable, open source library fo...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-29 14:37 UTC by Jeffrey C. Ollie
Modified: 2012-07-20 21:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-20 21:14:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jeffrey C. Ollie 2011-04-29 14:37:25 UTC
Spec URL: http://jcollie.fedorapeople.org/liblogging.spec
SRPM URL: http://jcollie.fedorapeople.org/liblogging-0.7.1-1.src.rpm
Description:
Liblogging is an easy to use, portable, open source library for system
logging.

The original idea was to provide a very slim BEEP look-alike to
implement with a few hundred lines of code. Well, during development
new ideas popped up and the design goal now has evolved to provide a
library useful for all kinds of system logging.

Liblogging is unique in the way that it was specifically designed for
system logging and ease of use. There are many BEEP libraries out
there and most of them support the syslog reliable RAW
profile. However, these libraries have a very complex API, which is
overdone just for logging. Software implementers stay away from those
libraries. We hope that liblogging will make reliable syslog available
to everyone. There is a very short, easy to use and learn API.

Comment 1 Mario Blättermann 2011-04-29 15:11:21 UTC
The link to the source rpm seems to be broken.

Comment 2 Jeffrey C. Ollie 2011-04-29 18:47:24 UTC
Oops, sorry:

SRPM URL: http://jcollie.fedorapeople.org/liblogging-0.7.1-1.fc14.src.rpm

Comment 3 Susi Lehtola 2011-04-30 08:24:43 UTC
Instead of using
 %{__sed} -i 's/\r//' COPYING
 %{__sed} -i 's/\r//' AUTHORS
 %{__sed} -i 's/\r//' ChangeLog
 %{__sed} -i 's/\r//' README
to convert EOLs, please use e.g.
 for file in COPYING AUTHORS ChangeLog README; do
  sed -i 's/\r//' $file > $file.new && \
  touch -r $file $file.new && \
  mv $file.new $file
 done
which preserves time stamps.

Comment 4 Jeffrey C. Ollie 2011-05-02 18:59:50 UTC
(In reply to comment #3)
> Instead of using
>  %{__sed} -i 's/\r//' COPYING
>  %{__sed} -i 's/\r//' AUTHORS
>  %{__sed} -i 's/\r//' ChangeLog
>  %{__sed} -i 's/\r//' README
> to convert EOLs, please use e.g.
>  for file in COPYING AUTHORS ChangeLog README; do
>   sed -i 's/\r//' $file > $file.new && \
>   touch -r $file $file.new && \
>   mv $file.new $file
>  done
> which preserves time stamps.

Fixed.

Spec URL: http://jcollie.fedorapeople.org/liblogging.spec
SRPM URL: http://jcollie.fedorapeople.org/liblogging-0.7.1-2.src.rpm

Comment 5 Mario Blättermann 2011-05-02 19:23:28 UTC
The SRPM link is broken again. Would be useful for a Koji scratch build.

Comment 6 Jeffrey C. Ollie 2011-05-02 19:50:29 UTC
OOPS, sorry again.  That's what I get for staying up late to watch the news...

http://jcollie.fedorapeople.org/liblogging-0.7.1-2.fc14.src.rpm

Scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3045757

Comment 7 Mario Blättermann 2011-05-02 20:15:39 UTC
$ rpmlint -v *
liblogging.i686: I: checking
liblogging.i686: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan
liblogging.i686: I: checking-url http://www.liblogging.org/ (timeout 10 seconds)
liblogging.src: I: checking
liblogging.src: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan
liblogging.src: I: checking-url http://www.liblogging.org/ (timeout 10 seconds)
liblogging.src: I: checking-url http://download.rsyslog.com/liblogging/liblogging-0.7.1.tar.gz (timeout 10 seconds)
liblogging-debuginfo.i686: I: checking
liblogging-debuginfo.i686: I: checking-url http://www.liblogging.org/ (timeout 10 seconds)
liblogging-devel.i686: I: checking
liblogging-devel.i686: I: checking-url http://www.liblogging.org/ (timeout 10 seconds)
liblogging.spec: I: checking-url http://download.rsyslog.com/liblogging/liblogging-0.7.1.tar.gz (timeout 10 seconds)
4 packages and 1 specfiles checked; 0 errors, 2 warnings.

Besides the spelling errors, no further issues from rpmlint.

The docs in the -devel package are originally in a "html" subfolder. In my mind, it would be useful to don't mix the html stuff with the docs from the base package (AUTHORS etc.), keeping this subfolder in %{docdir}%{name}%{version}.

Comment 8 Mario Blättermann 2012-07-20 21:04:01 UTC
Any interest to keep this review request alive? Otherwise, we should close this bug for the time being.

Comment 9 Jeffrey C. Ollie 2012-07-20 21:14:10 UTC
I have no real interest in it anymore...


Note You need to log in before you can comment on or make changes to this bug.