Bug 700915 - fix missing string in usage output of liveimage-mount
Summary: fix missing string in usage output of liveimage-mount
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: livecd-tools
Version: 15
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-29 19:28 UTC by Chris Marcantonio
Modified: 2011-05-03 17:55 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-03 17:55:29 UTC
Type: ---


Attachments (Terms of Use)

Description Chris Marcantonio 2011-04-29 19:28:21 UTC
Description of problem:
The usage statement of liveimage-mount is missing a string in it's print statement, causing the default output to read:

sh-4.2$ liveimage-mount 
Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS]
sh-4.2$

This is of course a strictly cosmetic bug, and doesn't have any impact on the actual function of the tool.



Version-Release number of selected component (if applicable):
livecd-tools-15.6-1.fc15.i686



How reproducible:
Every time.



Steps to Reproduce:
1. install latest version of livecd-tools
2. run liveimage-mount in a fashion that generates a usage statement


  
Actual results:
Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS]



Expected results:
Usage: /usr/bin/liveimage-mount ISO.iso MOUNTPOINT [COMMAND] [ARGS]



Additional info:
Pretty simple one line patch to add the variable to the end of the print statement:

sh-4.2# diff liveimage-mount liveimage-mount.ORIG 
28c28
<     print "Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS]" % sys.argv[0]
---
>     print "Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS]"
sh-4.2#

Is sys.argv[0] acceptable here, or is it preferred to strip the path off the front of the filename first?

Comment 1 Brian Lane 2011-05-03 17:55:29 UTC
This has been changed on master with the addition of a bunch of new options.


Note You need to log in before you can comment on or make changes to this bug.