Spec URL: http://poetinha.fedorapeople.org/wlmproxy.spec SRPM URL: http://poetinha.fedorapeople.org/wlmproxy-0.1.2-1.fc15.src.rpm Description: wlmproxy is a transparent proxy server for the MSN protocol. It supports all versions of MSNP, from 8 up to 21.
I'll review this package.
There are only two things that I find to be not according to the Review Guidelines: - The MD5 of the tarball from Git and the tarball in the .src.rpm don't match - Please use %{_localstatedir} in the .spec file instead of "/var" I'll attach my detailed review which contains all items from the Review Guidelines.
Created attachment 496669 [details] Checklist of the package, according to https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
latest package files Spec URL: http://poetinha.fedorapeople.org/wlmproxy.spec SRPM URL: http://poetinha.fedorapeople.org/wlmproxy-0.1.2-2.fc15.src.rpm
I see that you've fixed the problems I found. - 'gzip -n' fixed the md5sum issue - You've fixed the scriptlet issue - As I see it, the rpmlint "E" error for wlmproxy.conf is intentional. I've also tested the package with a simple usecase and it appears to be working properly. I see no further obstacles for this package. The package is now APPROVED. Congratulations! :)
New Package SCM Request ======================= Package Name: wlmproxy Short Description: An advanced proxy for the MSN Messenger protocol Owners: poetinha Branches: f14 f15 el6 InitialCC:
Git done (by process-git-requests).
wlmproxy-0.1.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/wlmproxy-0.1.2-2.fc14
wlmproxy-0.1.2-2.fc14 has been pushed to the Fedora 14 testing repository.
wlmproxy-0.1.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/wlmproxy-0.1.2-2.el6
wlmproxy-0.1.2-2.fc14 has been pushed to the Fedora 14 stable repository.
wlmproxy-0.1.3-0.1.20110521git67984d2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wlmproxy-0.1.3-0.1.20110521git67984d2.fc15
wlmproxy-0.1.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
wlmproxy-0.1.3-0.1.20110521git67984d2.fc15 has been pushed to the Fedora 15 stable repository.