Spec URL: http://venemo.fedorapeople.org/sources/puzzle-master.spec SRPM URL: http://venemo.fedorapeople.org/sources/puzzle-master-1.2.2-1.fc15.src.rpm Description: This is a jigsaw puzzle game that lets you use your own images (and contains some built-in ones) for generating puzzles. You can decide the size and thus the difficulty of the puzzle.
I do
Rpmlint output [will@totoro rpmbuild]$ rpmlint SRPMS/puzzle-master-1.2.2-1.fc15.src.rpm puzzle-master.src: W: file-size-mismatch puzzle-master-1.2.2.tar.gz = 762626, http://venemo.fedorapeople.org/sources/puzzle-master-1.2.2.tar.gz = 762620 1 packages and 0 specfiles checked; 0 errors, 1 warnings. You should document how to generate the tarball instead of linking to the file on fedorapeople. http://fedoraproject.org/wiki/Packaging/SourceURL [will@totoro rpmbuild]$ rpmlint RPMS/x86_64/puzzle-master-1.2.2-1.fc15.x86_64.rpm puzzle-master.x86_64: E: script-without-shebang /usr/share/applications/puzzle-master.desktop puzzle-master.x86_64: W: no-manual-page-for-binary puzzle-master 1 packages and 0 specfiles checked; 1 errors, 1 warnings. [will@totoro rpmbuild]$ rpmlint puzzle-master puzzle-master.x86_64: E: script-without-shebang /usr/share/applications/puzzle-master.desktop puzzle-master.x86_64: W: no-manual-page-for-binary puzzle-master 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Looking at source, puzzle-master.desktop is executable. The permission can be fixed with %attr: %attr(644,root,root) %{_datadir}/applications/puzzle-master.desktop other files have wrong permissions too, like png images. Also check desktop-file-install usage: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
not reviewing: but, I couldn't even build the src.rpm because of: BuildRequires: pkgconfig(QtCore), pkgconfig(QtGui), pkgconfig(QtOpenGL) this line really needs to be the packages that we pull from the fedora repos have a peek at http://fedoraproject.org/wiki/PackagingGuidelines#BuildRequires
(In reply to comment #2) > You should document how to generate the tarball instead of linking to the > file on fedorapeople. The upstream author (which happens to be myself) puts the released tarball onto Fedorapeople. So I see nothing wrong with that. If you insist on the git instructions instead, I could of course include them in the .spec. > Looking at source, puzzle-master.desktop is executable. > > The permission can be fixed with %attr: > > %attr(644,root,root) %{_datadir}/applications/puzzle-master.desktop Thanks, I fixed the permissions for both the .desktop and the icon file. > other files have wrong permissions too, like png images. Only the icon file (puzzle-master.png) is relevant, the others are not in the package. (They are embedded into the executable by Qt.) > Also check desktop-file-install usage: > > http://fedoraproject.org/wiki/Packaging/Guidelines#desktop Okay, I added desktop-file-validate to my .spec file.
(In reply to comment #3) > but, I couldn't even build the src.rpm because of: > BuildRequires: pkgconfig(QtCore), pkgconfig(QtGui), pkgconfig(QtOpenGL) > this line really needs to be the packages that we pull from the fedora repos Not true, even mock can understand these and yum can resolve them too.
(In reply to comment #3) > not reviewing: > > but, I couldn't even build the src.rpm because of: > > BuildRequires: pkgconfig(QtCore), pkgconfig(QtGui), pkgconfig(QtOpenGL) > > this line really needs to be the packages that we pull from the fedora repos > > have a peek at http://fedoraproject.org/wiki/PackagingGuidelines#BuildRequires There is no reference to pkgconfig use in BuildRequires. You can also install using double quotes ("). It's OK.
Uploaded new version: http://venemo.fedorapeople.org/sources/puzzle-master.spec http://venemo.fedorapeople.org/sources/puzzle-master-1.2.2-2.fc15.src.rpm
This package is APPROVED.
New Package SCM Request ======================= Package Name: puzzle-master Short Description: Fun and addictive jigsaw puzzle game Owners: venemo Branches: f14 f15 el6 InitialCC: venemo
Git done (by process-git-requests).
puzzle-master-1.2.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/puzzle-master-1.2.2-2.fc15
puzzle-master-1.2.2-2.fc15 has been pushed to the Fedora 15 stable repository.