Bug 701841 - Review Request: cargo-parent - cargo parent pom
Summary: Review Request: cargo-parent - cargo parent pom
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 701840
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-04 02:57 UTC by Orion Poplawski
Modified: 2011-05-31 20:07 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-31 20:07:53 UTC
Type: ---
sochotni: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Orion Poplawski 2011-05-04 02:57:08 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/cargo-parent.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/cargo-parent-4.7-1.fc15.src.rpm
Description:
This package contains the cargo parent pom.

Comment 1 Stanislav Ochotnicky 2011-05-12 14:52:30 UTC
I'll review this

Comment 2 Stanislav Ochotnicky 2011-05-12 15:24:49 UTC
rpmlint:
cargo-parent.noarch: W: summary-not-capitalized C cargo parent pom
cargo-parent.noarch: W: invalid-url URL: http://cargo.codehaus.org/ <urlopen error timed out>
cargo-parent.noarch: W: no-documentation
cargo-parent.noarch: W: non-conffile-in-etc /etc/maven/fragments/cargo-parent
cargo-parent.src: W: summary-not-capitalized C cargo parent pom
cargo-parent.src: W: invalid-url Source0: cargo-parent-4.7.tar.gz
2 packages and 0 specfiles checked; 0 errors, 6 warnings.


Everything seems to be in order (including license, maven things, BRs/Rs) except for that summary (that needs improving to something a *bit* more descriptive). defattr macros are also not needed anymore (optional).

It would be nice to have above issues fixed but they are minor, package is APPROVED.

Comment 3 Orion Poplawski 2011-05-27 20:26:47 UTC
Updated summary to: Parent pom file for cargo.codehaus.org project

New Package SCM Request
=======================
Package Name: cargo-parent
Short Description: Parent pom file for cargo.codehaus.org project
Owners: orion
Branches: f15 f14 el6
InitialCC:

Comment 4 Jason Tibbitts 2011-05-28 15:07:54 UTC
Git done (by process-git-requests).

Comment 5 Orion Poplawski 2011-05-31 20:07:53 UTC
Checked in and built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.