Bug 704559 - Possible problems found by static analysis of code
Summary: Possible problems found by static analysis of code
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: patchutils
Version: 15
Hardware: All
OS: All
low
low
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-13 15:26 UTC by Jiri Popelka
Modified: 2012-07-16 16:34 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-16 16:34:12 UTC
Type: ---

Attachments (Terms of Use)
Avoid possible null pointer access (706 bytes, text/plain)
2011-05-13 15:28 UTC, Jiri Popelka 		no flags Details
Fixed suspicious sizeofs (940 bytes, text/plain)
2011-05-13 15:28 UTC, Jiri Popelka 		no flags Details
Fix some possible resource leaks (4.03 KB, text/plain)
2011-05-13 15:29 UTC, Jiri Popelka 		no flags Details
error log (2.25 KB, text/plain)
2011-05-13 15:34 UTC, Jiri Popelka 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Jiri Popelka 2011-05-13 15:26:27 UTC 
Description of problem:
Static analysis of the code with/without applied patches discovered
some possible problems in the code.

Version-Release number of selected component (if applicable):
patchutils-0.3.2-1.fc15
Comment 1 Jiri Popelka 2011-05-13 15:28:31 UTC 
Created attachment 498786 [details]
Avoid possible null pointer access
Comment 2 Jiri Popelka 2011-05-13 15:28:56 UTC 
Created attachment 498787 [details]
Fixed suspicious sizeofs
Comment 3 Jiri Popelka 2011-05-13 15:29:38 UTC 
Created attachment 498788 [details]
Fix some possible resource leaks

Tim, I'm not sure about some of them so please check it.
Comment 4 Jiri Popelka 2011-05-13 15:34:15 UTC 
Created attachment 498790 [details]
error log

There's one reported problem where I'm not able to decide whether it's really a problem and how to properly treat it so I'm leaving it up to you :-)
Comment 5 Tim Waugh 2011-05-20 13:02:32 UTC 
Thanks, applied upstream, with some small changes to the resource leak patch.

There was indeed a problem discovered by the log in comment #4.  I've fixed that too.
Note You need to log in before you can comment on or make changes to this bug.