Bug 705101 - Need to package /etc/logrotate.d/iwhd
Summary: Need to package /etc/logrotate.d/iwhd
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: iwhd
Version: 1.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
Assignee: Pete Zaitcev
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks: 698373
TreeView+ depends on / blocked
 
Reported: 2011-05-16 16:01 UTC by Pete Zaitcev
Modified: 2012-01-26 12:28 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-19 19:37:24 UTC


Attachments (Terms of Use)
candidate patch 1 (6.07 KB, patch)
2011-07-08 04:22 UTC, Pete Zaitcev
no flags Details | Diff

Description Pete Zaitcev 2011-05-16 16:01:09 UTC
Description of problem:

iwhd's log file grows unbound

[root@locutus ~]# ls -l /var/log/iwhd.log 
-rw-r--r--. 1 root root 10121121543 Apr 26 16:41 /var/log/iwhd.log
[root@locutus ~]# 

Version-Release number of selected component (if applicable):

iwhd-0.92-1.p1.fc14.x86_64

How reproducible:

synchronous

Steps to Reproduce:
1. run iwhd
  
Actual results:

Logs are not rotated.

Expected results:

Logs rotated.

Additional info:

Comment 2 Pete Zaitcev 2011-07-01 22:27:07 UTC
We need to switch to syslog, because it's impossible to rotate a raw
dump of stderr. Also, see bz#698373 for other logging improvements.

Comment 3 Pete Zaitcev 2011-07-08 03:54:13 UTC
Switching to syslog turned out harder than it looked, because there are
libraries to consider. For now we are just going to stick to writing
to a file, just open it explicitly for the kill -HUP to work.

Comment 4 Pete Zaitcev 2011-07-08 04:22:48 UTC
Created attachment 511839 [details]
candidate patch 1

Comment 5 Mark McLoughlin 2011-07-08 08:59:14 UTC
Nice patch Pete.

How about a combination of your patch and this little logging API:

https://github.com/markmc/iwhd/commit/44c26d5800

That way we at least get timestamps (for #698373) from the error() and DPRINTF() calls

Comment 7 wes hayutin 2011-09-28 16:41:57 UTC
making sure all the bugs are at the right version for future queries

Comment 9 Brad P. Crochet 2011-11-07 18:40:38 UTC
Verified:

[root@qeblade33 ~]# rpm -ql iwhd | grep logrotate
/etc/logrotate.d/iwhd


[root@qeblade33 ~]# rpm -q iwhd 
iwhd-0.991-1.el6.x86_64


Note You need to log in before you can comment on or make changes to this bug.