Bug 705143 - qemu-kvm-rhel6.git srpm build should update makefile BUILD to current tag..
Summary: qemu-kvm-rhel6.git srpm build should update makefile BUILD to current tag..
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Eduardo Habkost
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-16 18:54 UTC by john cooper
Modified: 2014-07-25 03:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-20 18:54:49 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description john cooper 2011-05-16 18:54:06 UTC 
[submitting as a place holder so this doesn't get lost]

Description of problem:

The git srpm build in qemu-kvm-rhel6 doesn't update the
build version automatically to track the git tag which
is problematic.

Expected results:

srpm build from git tree should update build version to
the current tag.

Additional info:

In this case:

--- a/redhat/Makefile.common
+++ b/redhat/Makefile.common
@@ -14,7 +14,7 @@ REDHAT:=$(shell pwd)
 RPM:=$(REDHAT)/rpm
 SRPMS:=$(RPM)/SRPMS
 SOURCES:=$(RPM)/SOURCES
-BUILD:=113
+BUILD:=159
 PREBUILD=2.
 DIST=.el6
 PKGNAME=$(COMMON_NAME)

"BUILD" needs to be set to the most recent tag of 159.
This is a TBD according to Eduardo although I probably
will just hack a wrapper script to poke it per build
lest I forget this nugget.

See commit 55141fddd99a6a5eaccd558b9b5e14fe5ffe925a for
an earlier skeleton.
Comment 2 Dor Laor 2011-05-19 20:05:31 UTC 
John, please send the patch to rhvirt
Note You need to log in before you can comment on or make changes to this bug.