Bug 706063 - Some proposed template clean ups and fixes for policycoreutils-gui
Summary: Some proposed template clean ups and fixes for policycoreutils-gui
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: policycoreutils
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Walsh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-19 11:30 UTC by Dominick Grift
Modified: 2011-11-08 21:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-08 21:54:23 UTC
Type: ---

Attachments (Terms of Use)
tab fixes in boolean template (1.48 KB, patch)
2011-05-19 11:32 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in etc_rw template (1.96 KB, patch)
2011-05-19 11:33 UTC, Dominick Grift 		no flags Details | Diff
various clean ups to executable template (4.51 KB, patch)
2011-05-19 11:33 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in rw template (2.05 KB, patch)
2011-05-19 11:34 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in script template (2.51 KB, patch)
2011-05-19 11:35 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in tmp template (2.28 KB, patch)
2011-05-19 11:35 UTC, Dominick Grift 		no flags Details | Diff
various clean ups in user template (3.20 KB, patch)
2011-05-19 11:36 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in var_lib template (4.94 KB, patch)
2011-05-19 11:37 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in var_log template (3.46 KB, patch)
2011-05-19 11:37 UTC, Dominick Grift 		no flags Details | Diff
fix stream connect pattern template in var_run template (1.69 KB, patch)
2011-05-19 11:38 UTC, Dominick Grift 		no flags Details | Diff
tab fixes in var_spool template (1.53 KB, patch)
2011-05-19 11:39 UTC, Dominick Grift 		no flags Details | Diff
space fix in boolean template (740 bytes, patch)
2011-05-19 11:39 UTC, Dominick Grift 		no flags Details | Diff
r_file_perms is deprecated use read_file_perms in etc_rw template (914 bytes, patch)
2011-05-19 11:40 UTC, Dominick Grift 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Dominick Grift 2011-05-19 11:30:25 UTC 
Description of problem:
Clean up templates to be more in line with upstream style requirements.

If a person submits a policy that was generated with polgen and the policy gets included it is best that the policy is in line (as much as possible) with the upstream style requirements.

For example, i have my eclipse slide configured to convert spaces to tabs. So if i edit a policy that was generated with polgen, then eclipse will automatically convert spaces to tabs, Which messes up the lay out.

Besides that, the included patches have other minor style fixes.

One patch actually fixes a bug, where the stream connect pattern template was missing a required parameter.

Version-Release number of selected component (if applicable):
Patches were done against v2.0.86

Additional info:

caution though that included patches were actually untested.
Comment 1 Dominick Grift 2011-05-19 11:32:16 UTC 
Created attachment 499804 [details]
tab fixes in boolean template
Comment 2 Dominick Grift 2011-05-19 11:33:12 UTC 
Created attachment 499805 [details]
tab fixes in etc_rw template
Comment 3 Dominick Grift 2011-05-19 11:33:54 UTC 
Created attachment 499806 [details]
various clean ups to executable template
Comment 4 Dominick Grift 2011-05-19 11:34:35 UTC 
Created attachment 499807 [details]
tab fixes in rw template
Comment 5 Dominick Grift 2011-05-19 11:35:13 UTC 
Created attachment 499808 [details]
tab fixes in script template
Comment 6 Dominick Grift 2011-05-19 11:35:52 UTC 
Created attachment 499809 [details]
tab fixes in tmp template
Comment 7 Dominick Grift 2011-05-19 11:36:36 UTC 
Created attachment 499810 [details]
various clean ups in user template
Comment 8 Dominick Grift 2011-05-19 11:37:09 UTC 
Created attachment 499811 [details]
tab fixes in var_lib template
Comment 9 Dominick Grift 2011-05-19 11:37:40 UTC 
Created attachment 499812 [details]
tab fixes in var_log template
Comment 10 Dominick Grift 2011-05-19 11:38:29 UTC 
Created attachment 499813 [details]
fix stream connect pattern template in var_run template
Comment 11 Dominick Grift 2011-05-19 11:39:05 UTC 
Created attachment 499814 [details]
tab fixes in var_spool template
Comment 12 Dominick Grift 2011-05-19 11:39:45 UTC 
Created attachment 499815 [details]
space fix in boolean template
Comment 13 Dominick Grift 2011-05-19 11:40:41 UTC 
Created attachment 499816 [details]
r_file_perms is deprecated use read_file_perms in etc_rw template
Comment 14 Daniel Walsh 2011-11-08 21:54:23 UTC 
Fixed in policycoreutils-2.1.4-7.fc16
Note You need to log in before you can comment on or make changes to this bug.