Bug 707449 - Package (re)signing aborts on identical signature
Summary: Package (re)signing aborts on identical signature
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: rpm
Version: 6.1
Hardware: All
OS: Linux
high
medium
Target Milestone: rc
: ---
Assignee: Panu Matilainen
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
: 744880 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-25 06:25 UTC by Panu Matilainen
Modified: 2018-11-26 18:53 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 18:18:30 UTC
Target Upstream Version:


Attachments (Terms of Use)
Patch to skip already signed pkgs (460 bytes, patch)
2011-10-11 13:22 UTC, Mika Ilmaranta
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1737 0 normal SHIPPED_LIVE rpm bug fix and enhancement update 2011-12-06 01:01:53 UTC

Description Panu Matilainen 2011-05-25 06:25:54 UTC
Description of problem:

When (re)signing, packages which are already signed with the same key cause the entire signing process to abort when it should simply skip over such packages.

Version-Release number of selected component (if applicable):
rpm-4.8.0-16.el6

How reproducible:
Always (or almost so, there seems to be some other bug in the "identical signature" detection)

Steps to Reproduce:
1. Grab a few rpms
2. rpm --addsign *.rpm
3. Add a few more rpms
4. rpm --addsign *.rpm
  
Actual results:
Step 4 aborts when it finds a package already signed with the same key, possibly leaving others unsigned.

Expected results:
All packages should be processed: packages with identical signature should be skipped and others (re)signed.

Additional info:
This is a regression from RHEL 6.0 due to a backporting error.

Comment 3 Panu Matilainen 2011-05-25 07:31:55 UTC
Okay it is always reproducable, the "other bug" was actually just missing error message on failure to replace original package instead of a bug in identical signature detection.

Comment 8 Panu Matilainen 2011-10-11 05:39:06 UTC
*** Bug 744880 has been marked as a duplicate of this bug. ***

Comment 9 Mika Ilmaranta 2011-10-11 13:22:29 UTC
Created attachment 527441 [details]
Patch to skip already signed pkgs

This patch makes rpm --resign to skip pkgs already signed with identical signature.

I didn't check if some clean up should be done before continue so this may introduce memory leaks.

Comment 10 errata-xmlrpc 2011-12-06 18:18:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1737.html


Note You need to log in before you can comment on or make changes to this bug.