Bug 708522 - avoid a build failure without downstream patches and introduce a way to exclude test-suite
Summary: avoid a build failure without downstream patches and introduce a way to exclu...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: valgrind
Version: 6.1
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: ---
Assignee: Jakub Jelinek
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-27 21:02 UTC by Kamil Dudka
Modified: 2011-12-06 16:28 UTC (History)
2 users (show)

Fixed In Version: valgrind-3.6.0-4.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 16:28:01 UTC
Target Upstream Version:

Attachments (Terms of Use)
proposed fix (909 bytes, patch)
2011-05-27 21:03 UTC, Kamil Dudka 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1651 0 normal SHIPPED_LIVE valgrind bug fix and enhancement update 2011-12-06 00:50:27 UTC

Description Kamil Dudka 2011-05-27 21:02:24 UTC 
Version-Release number of selected component (if applicable):
valgrind-3.6.0-3.el6


Steps to Reproduce:
1. rpmbuild --define '__patch /bin/true' --rebuild valgrind-3.6.0-3.el6.src.rpm

  
Actual results:
DEBUG: + chmod 755 none/tests/s390x/filter_stderr
DEBUG: chmod: cannot access `none/tests/s390x/filter_stderr': No such file or directory
DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.oesq2p (%prep)
DEBUG:     Bad exit status from /var/tmp/rpm-tmp.oesq2p (%prep)


Additional info:
The proposed change is required for Coverity to scan defects in downstream
patches separately.
Comment 1 Kamil Dudka 2011-05-27 21:03:27 UTC 
Created attachment 501396 [details]
proposed fix
Comment 3 Jakub Jelinek 2011-06-09 18:53:02 UTC 
For the time being try rawhide valgrind (3.6.1-3.fc16).
The first hunk is the same there, the testsuite is (hopefully) solved by moving it into %check section.
Comment 4 Kamil Dudka 2011-06-09 21:38:40 UTC 
valgrind-3.6.1-3.1.fc16 is much more friendly with the Coverity analysis.  I only needed the following one-line patch to get the vanilla build running with glibc-2.14:

--- a/valgrind.spec
+++ b/valgrind.spec
@@ -105,7 +105,7 @@
 %patch5 -p1
 %patch6 -p1
 %patch7 -p1
-%patch8 -p1
+%patch8 -p1 %{?_rawbuild}
 %patch9 -p1
 %patch10 -p1
 %patch11 -p1
Comment 10 errata-xmlrpc 2011-12-06 16:28:01 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1651.html
Note You need to log in before you can comment on or make changes to this bug.