Spec URL: http://people.redhat.com/vondruch/rubygem-open4.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-open4-1.0.1-1.fc16.src.rpm Description: Manage child processes and their IO handles easily Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3100053gvim
- rpmlint OK - package must be named according to Guidelines OK - spec file name must match the base package %{name} OK - package must meet the Packaging Guidelines OK - package must be licensed with Fedora approved license ? - license field must match actual license ? - text of the license in its own file must be included in %doc OK - sources must match the upstream source OK - package MUST successfully compile and build OK - architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK - build dependencies must be listed in BuildRequires ? - handle locales properly with %find_lang macro OK - shared library files must call ldconfig in %post(un) OK - packages must NOT bundle system libraries OK - package must own all directories that it creates OK - permissions on files must be set properly OK - package must consistently use macros OK - package must contain code, or permissable content OK - large documentation must go in a -doc OK - %doc must not affect the runtime of the application OK - header files must be in a -devel package OK - static libraries must be in a -static package OK - library files that end in .so (without suffix) must go in a -devel OK - devel package usually require base package OK - packages must NOT contain any .la libtool archives OK - GUI applications must include a %{name}.desktop file OK - packages must not own files or directories already owned by other packages OK Requires: rubygems >= 0 Why must be requires bigger than 0? Where is Ruby license stated? I didn't find it in package. You should have text of license in package. 'gem install' should be in install part of spec file.
'gem install' could be in prep because otherwise after fedpkg prep will be there only packed gem.
I have uploaded new revision: Spec URL: http://people.redhat.com/vondruch/rubygem-open4.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-open4-1.0.1-2.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3101742 (In reply to comment #1) > Requires: rubygems >= 0 > Why must be requires bigger than 0? Sorry, forgot to do some necessary cleanup. > Where is Ruby license stated? I didn't find it in package. https://github.com/ahoward/open4/blob/master/README#L365 Apparently the LICENSE file should be included in next upstream release which is not ready yet. https://github.com/ahoward/open4/commit/e3e61cda38b36cc280cbe3fe0a09e7baec5ab44b > You should have text of license in package. Is it worth of the work? I don't think so.
APPROVED
Thank you for your review. New Package SCM Request ======================= Package Name: vondruch Short Description: open4 is library for management of child processes Owners: vondruch Branches: InitialCC:
devel branch is created by default, and shouldn't be explicitly requested.
Git done (by process-git-requests).
Ups, now I have noticed rubygem-open4 is already in Fedora. I don't understand how I could missed that. Shame on me :/ *** This bug has been marked as a duplicate of bug 642577 ***
And me, and Marcela. At least one of us should have caught that. :)