SPEC: http://liangsuilong.fedorapeople.org/perl-Gtk2-Unique.spec SRPM: http://liangsuilong.fedorapeople.org/perl-Gtk2-Unique-0.05-1.fc15.src.rpm Description: Perl bindings for the C library "libunique" that provides a mechanism for writing single instance applications. If you launch a single instance application twice, the second instance will either just quit or will send a message to the running instance. Koji Result: F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3110959 Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3110984 Koji builds are successful. Rpmlint is silent too. The latest shutter is depending on perl-Gtk2-Unique, so the request is quite urgent.
Taking.
=== KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3111488 [x] Rpmlint output: perl-Gtk2-Unique.src: W: spelling-error Summary(en_US) libunique -> lib unique, lib-unique, uniqueness perl-Gtk2-Unique.src: W: spelling-error %description -l en_US libunique -> lib unique, lib-unique, uniqueness perl-Gtk2-Unique.x86_64: W: spelling-error Summary(en_US) libunique -> lib unique, lib-unique, uniqueness perl-Gtk2-Unique.x86_64: W: spelling-error %description -l en_US libunique -> lib unique, lib-unique, uniqueness perl-Gtk2-Unique.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Gtk2/Unique/Unique.so Unique.so()(64bit) perl-Gtk2-Unique.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Gtk2/Unique/Unique.so Unique.so()(64bit) perl-Gtk2-Unique.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gtk2/Unique/Install/unique-autogen.h perl-Gtk2-Unique.x86_64: W: manifest-in-perl-module /usr/share/doc/perl-Gtk2-Unique-0.05/MANIFEST perl-Gtk2-Unique.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/Gtk2/Unique/Install/unique-perl.h 2 packages and 1 specfiles checked; 0 errors, 9 warnings. Silent, this is not. The spelling mistakes are a false positive. Let's forget about them. The private-shared-object-provides warnings will go away if you just add %{?perl_default_filter} above the %description stanza. See https://fedoraproject.org/wiki/Perl_default_filter for more details. The MANIFEST should be removed. The include files should probably be put in a -devel subpackage unless there's a compelling reason not to. [x] Package is not relocatable. [x] Buildroot is correct Yup. Note that this is no longer needed. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!] License field in the package spec file matches the actual license. WTF ?! The package is licensed "GPL+ or Artistic" but the License field of the spec says "LGPLv2+". Where did this come from ? [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 0beb552933b765a017588563a71af123 Gtk2-Unique-0.05.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. Note that defattr is no longer needed. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [!] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: rawxhide.x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3111488 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the tests pass Cannot be done since tests require DISPLAY Please fix the errors I've pointed out.
Is this still urgent?
(In reply to comment #3) > Is this still urgent? I am so sorry that I was busy working and organizing Lovelock Event @ Canton. So I forgot to update the review request. Now all the thing had been done. SPEC: http://liangsuilong.fedorapeople.org/perl-Gtk2-Unique.spec SRPM: http://liangsuilong.fedorapeople.org/perl-Gtk2-Unique-0.05-2.fc15.src.rpm koji Result: http://koji.fedoraproject.org/koji/taskinfo?taskID=3141050 Review is urgent because shutter is still waiting this package.
(In reply to comment #2) > > [x] Rpmlint output: perl-Gtk2-Unique.src: W: spelling-error Summary(en_US) libunique -> lib unique, lib-unique, uniqueness perl-Gtk2-Unique.src: W: spelling-error %description -l en_US libunique -> lib unique, lib-unique, uniqueness perl-Gtk2-Unique.src: E: changelog-time-in-future 2011-06-19 perl-Gtk2-Unique.src:31: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 1) perl-Gtk2-Unique.spec:31: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 1) 1 packages and 1 specfiles checked; 1 errors, 4 warnings. As said before, the spelling mistakes are flase positives, rpmlint treats changelog entries as being done at noon so the changelog-time-in-future is a flase positive as well. Please use either tabs or spaces in your spec file (I prefer spaces but the choice is up to you). > The package is licensed "GPL+ or Artistic" but the License field of the spec > says "LGPLv2+". Where did this come from ? Spec file now says "GPL+ or Artistic" APPROVED.
(In reply to comment #5) > (In reply to comment #2) > > > > [x] Rpmlint output: > > perl-Gtk2-Unique.src: W: spelling-error Summary(en_US) libunique -> lib unique, > lib-unique, uniqueness > perl-Gtk2-Unique.src: W: spelling-error %description -l en_US libunique -> lib > unique, lib-unique, uniqueness > perl-Gtk2-Unique.src: E: changelog-time-in-future 2011-06-19 > perl-Gtk2-Unique.src:31: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: > line 1) > perl-Gtk2-Unique.spec:31: W: mixed-use-of-spaces-and-tabs (spaces: line 31, > tab: line 1) > 1 packages and 1 specfiles checked; 1 errors, 4 warnings. > > As said before, the spelling mistakes are flase positives, rpmlint treats > changelog entries as being done at noon so the changelog-time-in-future is a > flase positive as well. Please use either tabs or spaces in your spec file (I > prefer spaces but the choice is up to you). > > > The package is licensed "GPL+ or Artistic" but the License field of the spec > > says "LGPLv2+". Where did this come from ? > > Spec file now says "GPL+ or Artistic" > > APPROVED. Thank you very much! I request to push the package to Fedora git repository.
No scm request present, please see: https://fedoraproject.org/wiki/Package_SCM_admin_requests
New Package SCM Request ======================= Package Name: perl-Gtk2-Unique Short Description: Perl bindings for the C library "libunique" Owners: liangsuilong Branches: f14 f15 el6
please add perl-sig as InitialCC: All perl modules should do this.
New Package SCM Request ======================= Package Name: perl-Gtk2-Unique Short Description: Perl bindings for the C library "libunique" Owners: liangsuilong Branches: f14 f15 el6 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Gtk2-Unique-0.05-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Gtk2-Unique-0.05-2.fc15
perl-Gtk2-Unique-0.05-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Gtk2-Unique-0.05-2.fc14
perl-Gtk2-Unique-0.05-2.fc14 has been pushed to the Fedora 14 testing repository.
perl-Gtk2-Unique-0.05-2.fc14 has been pushed to the Fedora 14 stable repository.
perl-Gtk2-Unique-0.05-2.fc15 has been pushed to the Fedora 15 stable repository.