Spec URL: http://fkooman.fedorapeople.org/php-pecl-oauth/php-pecl-oauth.spec SRPM URL: http://fkooman.fedorapeople.org/php-pecl-oauth/php-pecl-oauth-1.1.0-2.fc15.src.rpm Description: OAuth is an authorization protocol built on top of HTTP which allows applications to securely access data without having to store usernames and passwords.
(Small update in BR (pcre) Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3127051 rpmlint: [fkooman@franet SPECS]$ rpmlint php-pecl-oauth.spec ../SRPMS/php-pecl-oauth-1.1.0-3.fc15.src.rpm ../RPMS/i686/php-pecl-oauth-1.1.0-3.fc15.i686.rpm php-pecl-oauth.src: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames php-pecl-oauth.i686: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames php-pecl-oauth.i686: W: private-shared-object-provides /usr/lib/php/modules/oauth.so oauth.so 2 packages and 1 specfiles checked; 0 errors, 3 warnings. [fkooman@franet SPECS]$ The last warning worries me a bit... See https://fedoraproject.org/wiki/Common_Rpmlint_issues#private-shared-object-provides, not sure I understand completely what is going on and how to fix it... Spec URL: http://fkooman.fedorapeople.org/php-pecl-oauth/php-pecl-oauth.spec SRPM URL: http://fkooman.fedorapeople.org/php-pecl-oauth/php-pecl-oauth-1.1.0-3.fc15.src.rpm
private-shared-object-provides => check others pecl extensions %{?filter_setup: %filter_provides_in %{php_extdir}/.*\.so$ %filter_setup }
There is no test provided by upstream, but you could, at least, provides a minimal %check section to check than the build module is loadable Something like: %check cd %{pecl_name}-%{version} php -n \ -d extension_dir=modules \ -d extension=%{pecl_name}.so \ --modules | grep OAuth
Thanks! Addressed both issues: [fkooman@franet SPECS]$ rpmlint php-pecl-oauth.spec ../SRPMS/php-pecl-oauth-1.1.0-4.fc15.src.rpm ../RPMS/i686/php-pecl-oauth-1.1.0-4.fc15.i686.rpm php-pecl-oauth.src: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames php-pecl-oauth.i686: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames 2 packages and 1 specfiles checked; 0 errors, 2 warnings. [fkooman@franet SPECS]$ Spec URL: http://fkooman.fedorapeople.org/php-pecl-oauth/php-pecl-oauth.spec SRPM URL: http://fkooman.fedorapeople.org/php-pecl-oauth/php-pecl-oauth-1.1.0-4.fc15.src.rpm
=== FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: php-pecl-oauth.spec: I: checking-url http://pecl.php.net/get/oauth-1.1.0.tgz (timeout 10 seconds) php-pecl-oauth.src: I: checking php-pecl-oauth.src: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames php-pecl-oauth.src: I: checking-url http://pecl.php.net/package/oauth (timeout 10 seconds) php-pecl-oauth.src: I: checking-url http://pecl.php.net/get/oauth-1.1.0.tgz (timeout 10 seconds) php-pecl-oauth.x86_64: I: checking php-pecl-oauth.x86_64: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames php-pecl-oauth.x86_64: W: incoherent-version-in-changelog 1.1.0-4 ['1.1.0-4.fc15.remi', '1.1.0-4.remi'] php-pecl-oauth.x86_64: I: checking-url http://pecl.php.net/package/oauth (timeout 10 seconds) php-pecl-oauth-debuginfo.x86_64: I: checking php-pecl-oauth-debuginfo.x86_64: I: checking-url http://pecl.php.net/package/oauth (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 3 warnings. [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the PHP specific items [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: BSD [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : 26359ba5f04848e725a97c9aef9713b6 oauth-1.1.0.tgz [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f15 x86_64 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Packages don't bundle copies of system librarie [x] Package is not relocatable. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [!] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [ ] Fully versioned dependency in subpackages with %{?_isa}, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI [-] All filenames in rpm packages must be valid UTF-8 [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Final requires php(zend-abi) = 20090626-x86-64 php(api) = 20090626-x86-64 /usr/bin/pecl ... [x] Final provides php-pecl(oauth) = 1.1.0 php-pecl-oauth = 1.1.0-4.fc15.remi php-pecl-oauth(x86-64) = 1.1.0-4.fc15.remi [x] Latest version is packaged. [-] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=3128201 [x] The package should compile and build into binary rpms on all supported architectures. Tested on: [!] Package functions as described. [x] If scriptlets are used, those scriptlets must be sane. [x] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [-] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. [-] The placement of pkgconfig(.pc) files is correct. [x] %check is present and the tests pass 2 minor issues, no blocker: - php_apiver macro is defined but never used. - phpinfo reports version 1.0-dev (instead of 1.1.0). please report this bug upstream ============ APPROVED ============
Thanks for the review! Issues: - I removed the macro - upstream in trunk has "fixed" this, by setting 1.1.1-dev now, I hope they remove the "-dev" when it is time to release (http://svn.php.net/viewvc/pecl/oauth/trunk/php_oauth.h?revision=311716&view=markup, line 72) for now I can patch this myself. or should I just leave it? - The trunk version has some tests included, when/if 1.1.1 is released I'll add those tests to the spec file as well... You want to be co-maintainer for this package? New Package SCM Request ======================= Package Name: php-pecl-oauth Short Description: PHP OAuth extension Owners: fkooman Branches: f14 f15 InitialCC:
Git done (by process-git-requests).
php-pecl-oauth-1.1.0-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-pecl-oauth-1.1.0-5.fc15
php-pecl-oauth-1.1.0-5.fc15 has been pushed to the Fedora 15 testing repository.
php-pecl-oauth-1.1.0-6.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-pecl-oauth-1.1.0-6.fc15
php-pecl-oauth-1.1.0-6.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: php-pecl-oauth New Branches: el6 Owners: tjikkun
Sander, is Francois on board with you maintaining the EL-6 branch?
Hi Jon, Yes he is: https://bugzilla.redhat.com/show_bug.cgi?id=848088#c3
Git done (by process-git-requests). Brilliant, thanks!
Package Change Request ====================== Package Name: php-pecl-oauth New Branches: epel7 Owners: fkooman remi