Bug 711126 - ibus: surrounding text support fails for the first syllable upon activation
Summary: ibus: surrounding text support fails for the first syllable upon activation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ibus-m17n
Version: 15
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Daiki Ueno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-06 15:58 UTC by Harshula Jayasuriya
Modified: 2011-06-24 17:56 UTC (History)
3 users (show)

Fixed In Version: ibus-m17n-1.3.2-5.fc15
Clone Of:
Environment:
Last Closed: 2011-06-24 17:55:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
workaround to request surrounding-text in advance (450 bytes, patch)
2011-06-07 06:49 UTC, Daiki Ueno
no flags Details | Diff

Description Harshula Jayasuriya 2011-06-06 15:58:11 UTC
Description of problem:
* As soon as IBus is activated, there seems to be a problem with surrounding text support for the first syllable typed.

Version-Release number of selected component (if applicable):
* ibus-1.3.99.20110408-5.fc15.x86_64
* ibus-m17n-1.3.2-3.fc15.x86_64

How reproducible:
* Consistently

Steps to Reproduce:
1. Open gedit
2. Activate IBus and select Sinhala phonetic-dynamic (m17n)
3. Deactivate and Activate IBus (this step may not be required)
4. Type "koko"
  
Actual results:
* කඔකො

Expected results:
* කොකො

Comment 1 Daiki Ueno 2011-06-07 05:00:14 UTC
Sorry for inconvenience.  When I replaced a local surrounding-text patch with the upstream one, I dropped Fedora specific code by mistake.

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3115152

Could you test it?

Comment 2 Harshula Jayasuriya 2011-06-07 05:44:22 UTC
Installing ibus-m17n-1.3.2-4.fc15.x86_64 and restarting IBus, I could still reproduce the bug. My guess is that the first surrounding text operation fails.

Comment 3 Daiki Ueno 2011-06-07 06:21:06 UTC
OK probably I got it.  Currently ibus turns on surrounding-text support first time when the engine requests surrounding-text, and I suspect si-phonetic-dynamic does not request surrounding-text until it is really needed (i.e. when "o" is pressed).  

Other m17n engines, such as wijesekera, have no problem with it since it checks surrounding-text in the init state of MIM.

I'll consider what fix is better.

(BTW I think this is not that urgent since it happens only the first time the engine requests surrounding-text.  I'll lower the priority/severity to normal).

Comment 4 Daiki Ueno 2011-06-07 06:49:52 UTC
Created attachment 503387 [details]
workaround to request surrounding-text in advance

Comment 5 Daiki Ueno 2011-06-07 06:54:10 UTC
I figured out that this cannot be easily fixed in ibus side.  Couldn't it fixed in MIM files (patch attached to comment 4)?  Do you know any other MIMs which have similar problems?

Comment 6 Harshula Jayasuriya 2011-06-07 06:56:58 UTC
(In reply to comment #4)
> Created attachment 503387 [details]
> workaround to request surrounding-text in advance

Does that work for you? I just get English letters.

Comment 7 Harshula Jayasuriya 2011-06-07 06:58:17 UTC
correction ... it does work for me.

Comment 8 Harshula Jayasuriya 2011-06-07 07:00:10 UTC
Send your patch to m17n folks and explain why and see what they think.

Comment 9 Daiki Ueno 2011-06-15 01:43:33 UTC
I'm going to fix this by adding a dummy ibus_engine_get_surrounding_text() call in ibus_m17n_engine_enable().

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3131687

Could you test again?

Comment 10 Harshula Jayasuriya 2011-06-15 03:10:30 UTC
I backed out the patch to the MIM, restarted IBus. I can not reproduce the bug with the latest build of ibus-m17n. Thanks!

Comment 11 Fedora Update System 2011-06-15 03:57:55 UTC
ibus-m17n-1.3.2-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ibus-m17n-1.3.2-5.fc14

Comment 12 Fedora Update System 2011-06-15 03:58:04 UTC
ibus-m17n-1.3.2-5.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ibus-m17n-1.3.2-5.fc15

Comment 13 Fedora Update System 2011-06-15 18:28:34 UTC
Package ibus-m17n-1.3.2-5.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ibus-m17n-1.3.2-5.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/ibus-m17n-1.3.2-5.fc15
then log in and leave karma (feedback).

Comment 14 Fedora Update System 2011-06-24 17:55:48 UTC
ibus-m17n-1.3.2-5.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2011-06-24 17:56:52 UTC
ibus-m17n-1.3.2-5.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.