Bug 712558 - Gallery2 fails to save path to jpegtran in module.
Summary: Gallery2 fails to save path to jpegtran in module.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gallery2
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-11 05:04 UTC by Amit
Modified: 2011-12-21 17:02 UTC (History)
3 users (show)

Fixed In Version: gallery2-2.3.1-4.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-21 16:56:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Protoype code for fixing this bug (639 bytes, patch)
2011-12-07 04:34 UTC, Masatake YAMATO
no flags Details | Diff

Description Amit 2011-06-11 05:04:56 UTC
Description of problem:

When I try to test the jpegtran binary in the gallery2-jpegtran module, it fails when it test rotation.  When trying to save, i get "The path you entered doesn't contain a valid jpegtran binary. Use the 'test' button to check where the error is." error. However, it passes when it does crop.  I tried with the binary from F14 libjpeg-turbo-utils from 1.0.1-1 and libjpeg-turbo-utils from 1.1.0-2.

The issue occurs with the binary 1.1.0-2 but with 1.0.1-1, it is ok with the rotate and saving, but fails when it test crop.

Version-Release number of selected component (if applicable):
libjpeg-turbo-utils-1.1.0-2.fc15.i686

How reproducible:

Steps to Reproduce:
1. Install Gallery2
2. Install Gallery2-jpegtran module
3. Install libjpeg-turbo-utils
4. Configure gallery2-jpegtran module with the path to the binary
5. Select Test
6. Select Save
  
Actual results:
Rotate test fails and fails to save the path to the binary

Expected results:
Rotate and Crop tests successful and can save the path.

Additional info:

Comment 1 Adam Tkac 2011-07-11 15:13:49 UTC
I tried to install gallery2 with the jpegtran plugin and you are right the installation failed. Per logs gallery use following command to test jpegtran's rotate support:

Executing: ( "/usr/bin/jpegtran"  "-verbose"  "-copy"  "all"  "-rotate" 
"90"  "-outfile"  "/srv/gallery2/tmp/jpgt_ZLq9K4" 
"/usr/share/gallery2/modules/jpegtran/data/test.jpg" )

I tried to perform this command with both 1.1.0 and 1.0.1 jpegtran and output had same md5sums in both cases. Since one output is considered as fine and second is considered as faulty, I assume this is gallery2 issue, not libjpeg-turbo (because images are same).

Reassigning to gallery2 for further inspection.

Comment 2 Masatake YAMATO 2011-12-07 04:34:57 UTC
Created attachment 541722 [details]
Protoype code for fixing this bug

It seems that the output of version/copyright information of libjpeg-turbo-utils is changed. Please, try the attached patch.
I looked at the upstream project, but it seems that the developers' interests are moved to gallery3. So I submit the patch here.

Comment 3 Masatake YAMATO 2011-12-07 04:36:25 UTC
The bug is reproduced on f16.

Comment 4 Gwyn Ciesla 2011-12-07 17:28:12 UTC
Thanks, I've built in rawhide, I'll build for f15 and f16 and get an update out.

Comment 5 Fedora Update System 2011-12-07 17:43:43 UTC
gallery2-2.3.1-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/gallery2-2.3.1-4.fc16

Comment 6 Fedora Update System 2011-12-07 17:43:51 UTC
gallery2-2.3.1-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/gallery2-2.3.1-4.fc15

Comment 7 Fedora Update System 2011-12-10 19:45:53 UTC
Package gallery2-2.3.1-4.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gallery2-2.3.1-4.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-16875/gallery2-2.3.1-4.fc16
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2011-12-21 16:56:18 UTC
gallery2-2.3.1-4.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2011-12-21 17:02:19 UTC
gallery2-2.3.1-4.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.