Bug 712991 - include RPM noarch in /usr/share/magic
Summary: include RPM noarch in /usr/share/magic
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: file
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Kaluža
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 712992
TreeView+ depends on / blocked
 
Reported: 2011-06-13 20:13 UTC by James M. Leddy
Modified: 2014-08-11 05:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 712992 (view as bug list)
Environment:
Last Closed: 2011-06-14 06:10:06 UTC
Type: ---


Attachments (Terms of Use)
magic.patch (478 bytes, patch)
2011-06-13 20:13 UTC, James M. Leddy
no flags Details | Diff
revised-magic.patch (1.54 KB, patch)
2011-06-13 22:47 UTC, James M. Leddy
no flags Details | Diff
revised-magic.patch (1.53 KB, patch)
2011-06-13 22:51 UTC, James M. Leddy
no flags Details | Diff

Description James M. Leddy 2011-06-13 20:13:19 UTC
Description of problem:

Hi, I would like noarch packages to have additional detail in /usr/share/magic

Version-Release number of selected component (if applicable):

file-5.07-2.fc15.x86_64

How reproducible:

Always

Steps to Reproduce:
1. file *noarch.rpm
2. See no additional arch detail
3.
  
Actual results:


$ file xguest-1.0.9-2.el6.noarch.rpm 
xguest-1.0.9-2.el6.noarch.rpm: RPM v3.0 bin


Expected results:

$ file xguest-1.0.9-2.el6.noarch.rpm 
xguest-1.0.9-2.el6.noarch.rpm: RPM v3.0 bin noarch


Additional info:

diff -c /home/james/magic\~ /home/james/magic
*** /home/james/magic~	2011-06-13 16:00:37.815627201 -0400
--- /home/james/magic	2011-06-13 16:01:08.373320151 -0400
***************
*** 14784,14789 ****
--- 14784,14790 ----
  >>>8	beshort		16		PowerPC64
  >>>8	beshort		17		SuperH
  >>>8	beshort		18		Xtensa
+ >>>8    beshort         255             noarch
  
  #delta RPM    Daniel Novotny (dnovotny)
  0	string	drpm	Delta RPM

Diff finished.  Mon Jun 13 16:09:30 2011

Comment 1 James M. Leddy 2011-06-13 20:13:51 UTC
Created attachment 504536 [details]
magic.patch

Comment 2 James M. Leddy 2011-06-13 22:47:11 UTC
Created attachment 504563 [details]
revised-magic.patch

This is actually not sufficient. There are some packages, for example, asterisk-sounds-core-fr-sln16-1.4.20-1.el6.noarch.rpm, that identify as something other than RPM. The easiest solution is to just have the first 8 bytes match as in this patch.

Comment 3 James M. Leddy 2011-06-13 22:51:04 UTC
Created attachment 504564 [details]
revised-magic.patch


Note You need to log in before you can comment on or make changes to this bug.