Hide Forgot
Spec URL: http://kalev.fedorapeople.org/harfbuzz.spec SRPM URL: http://kalev.fedorapeople.org/harfbuzz-0.6.0-1.fc15.src.rpm Description: HarfBuzz is an implementation of the OpenType Layout engine. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3130477
Builds fine in mock. rpmlint says: rpmlint /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/RPMS/harfbuzz-* harfbuzz.x86_64: W: no-manual-page-for-binary hb-view harfbuzz-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. which is fine. Formal review to follow.
I think hb-view is probably better off in the -devel package ? Isn't that mostly a debug/demo thing ? I don't think it is interesting for most people who just install the library because pango is (going to) depend on it.
Package name: ok Spec file name: ok Packaging guidelines: ok License: ok License field: ok License file: ok Spec file language: ok Spec file readable: yes Upstream sources: ok Buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok permissions: ok (I just learned that %defattr is no longer required) macro use: ok permissable content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok Looks fine; approved
(In reply to comment #2) > I think hb-view is probably better off in the -devel package ? > Isn't that mostly a debug/demo thing ? I don't think it is interesting for most > people who just install the library because pango is (going to) depend on it. Good idea, I'll move it to -devel when importing the new package. Thanks for the review!
New Package SCM Request ======================= Package Name: harfbuzz Short Description: Text shaping library Owners: kalev mclasen Branches: InitialCC:
Git done (by process-git-requests).
Package imported and built; closing the ticket.
No package depends on this package, so I think its ok to branch for f15 also. Can this package be built for F15? Benefit I see, people who generally don't use rawhide but current stable release can also work on harfbuzz.