Hide Forgot
Created attachment 504665 [details] Proposed solution for the machdep.cpp /src/coolkey/machdep.cpp:366 - Function "SHMem *SHMem::initSegment" returns NULL without freeing the variable buf. Please also check missing return value control of function KYBuffer_AppendShort (/src/libckyapplet/cky_applet.c:799). Version-Release number of selected component (if applicable): 1.1.0 Additional info: These defects were not present in current supported version of coolkey package.
> Please also check missing return value control of function What does this mean. The the return value of CKYBuffer_AppendShort is ignored (true in lots of places, not just cky_applet.c). Or does it mean that there is a path where CKYBuffer_AppendShort does not return a status. This makes more sense for a tool to point out, but CKYBuffer_AppendShort is not defined in cky_applet.c, and it does properly return values. >/src/coolkey/machdep.cpp:366 - Function "SHMem *SHMem::initSegment" returns >NULL without freeing the variable buf. I'll be updating the patch. buf was alloc'd from calloc, so free(buf); is the appropriate way of freeing the buffer. bob
Created attachment 566682 [details] Updated patch to fix memory leak
Patch built in coolkey-1.1.0-20.el6
Tested as sanity only. Version :: coolkey-1.1.0-20.el6 Regression tests for SSO using Gemalto 64K smart card looks good. Smart cards Safenet 330J, Gemalto 64K, CAC card Gemalto GCX4 72K, CAC card Oberthur ID one V5.2, CAC card Gemalto TOPDLGX4 144 and PIV card on a omnikey 3121 reader recognized successfully by ESC. Moving to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2012-0948.html