Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Created attachment 504665[details]
Proposed solution for the machdep.cpp
/src/coolkey/machdep.cpp:366 - Function "SHMem *SHMem::initSegment" returns NULL without freeing the variable buf.
Please also check missing return value control of function KYBuffer_AppendShort (/src/libckyapplet/cky_applet.c:799).
Version-Release number of selected component (if applicable):
1.1.0
Additional info: These defects were not present in current supported version of
coolkey package.
> Please also check missing return value control of function
What does this mean. The the return value of CKYBuffer_AppendShort is ignored (true in lots of places, not just cky_applet.c). Or does it mean that there is a path where CKYBuffer_AppendShort does not return a status. This makes more sense for a tool to point out, but CKYBuffer_AppendShort is not defined in cky_applet.c, and it does properly return values.
>/src/coolkey/machdep.cpp:366 - Function "SHMem *SHMem::initSegment" returns
>NULL without freeing the variable buf.
I'll be updating the patch. buf was alloc'd from calloc, so free(buf); is the appropriate way of freeing the buffer.
bob
Tested as sanity only.
Version :: coolkey-1.1.0-20.el6
Regression tests for SSO using Gemalto 64K smart card looks good. Smart cards Safenet 330J, Gemalto 64K, CAC card Gemalto GCX4 72K, CAC card Oberthur ID one V5.2, CAC card Gemalto TOPDLGX4 144 and PIV card on a omnikey 3121 reader recognized successfully by ESC.
Moving to VERIFIED.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2012-0948.html
Created attachment 504665 [details] Proposed solution for the machdep.cpp /src/coolkey/machdep.cpp:366 - Function "SHMem *SHMem::initSegment" returns NULL without freeing the variable buf. Please also check missing return value control of function KYBuffer_AppendShort (/src/libckyapplet/cky_applet.c:799). Version-Release number of selected component (if applicable): 1.1.0 Additional info: These defects were not present in current supported version of coolkey package.