looks good (after informal review)

http://koji.fedoraproject.org/koji/taskinfo?taskID=3150513

Taking this for review.

* Please remove ruby_sitelib definition
  - This macro is useful only for gems with binary extension, which is not 
    this case
* License
  - According to LICENSE file, the license should be MIT
* Requires versions:
  - Please remove the >= 0 versions, which is default
* Each Ruby package must indicate the Ruby ABI version it depends on
  - Please add Requires and BuildRequires: ruby(abi) = 1.8
  - I prefer also to depend explicitly on ruby, since JRuby are probably comming
    into Fedora soon
* Please install gem with --bindir flag
  - --bindir .%{_bindir} should be used instead of some magic lines which moves
    the executables around.
* Please execute the test suite.
  - This needs:
    BuildRequires: rubygem(nokogiri) >= 1.4.1
    BuildRequires: rubygem(builder)
  - and the %check section:
    %check
    pushd %{buildroot}%{geminstdir}
    testrb -I lib test/test_*.rb
    popd
* What is the puprose of vmodl.db file?
  - Is it necessary for runtime?
  - Is it database?
  - Is it readonly or should it be modifiable?
  - It seems to be referenced inrbvmomi/devel/analyze-vim-declarations.rb so it
    looks like some debug output to me.

*** Bug 719949 has been marked as a duplicate of this bug. ***

Hi Vit Ondruch,

I am submitting the new version of spec file with the suggestions/bugfix you suggested.

http://crucco.razorinc.org/fedora/rubygem-rbvmomi-1.2.3.spec
http://crucco.razorinc.org/fedora/rubygem-rbvmomi-1.2.3-2.fc14.src.rpm


Let me know if it's all you need.

Thanks.

* It doesn't look like you have uploaded the updated .spec file. However 
  that is not a showstopper. I'll take the .spec from .srpm for review.

* MUST: The spec file name must match the base package %{name}, in the format
  %{name}.spec unless your package has an exemption.
  - i.e. please name rename rubygem-rbvmomi-1.2.3.spec => rubygem-rbvmomi.spec


rpmlint output OK.
Koji build OK: http://koji.fedoraproject.org/koji/taskinfo?taskID=3193050


Please don't forget to rename the .spec file before import. Otherwise the package looks good, so it is APPROVED

New Package CVS Request
=======================
Package Name: rubygem-rbvmomi
Short Description: Ruby interface to the VMware vSphere API
Owners: mfojtik
Branches: F-14 F-15 EL-5 El-6

Git done (by process-git-requests).

Corrected EL-6 branch name.

rubygem-rbvmomi-1.2.3-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rbvmomi-1.2.3-2.fc14

rubygem-rbvmomi-1.2.3-2.fc14 has been pushed to the Fedora 14 stable repository.

Package Change Request
======================
Package Name: rubygem-rbvmomi
New Branches: epel7
Owners: tdawson

Git done (by process-git-requests).