Spec URL: http://www.auroralinux.org/people/spot/review/new/sar2.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/sar2-2.3.0-1.fc15.src.rpm Description: Search and Rescue II is a rescue helicopter simulator for Linux. It features several missions in which the player pilots a helicopter in order to rescue people in distress. There are several scenarios and helicopter models. Search and Rescue II has a strong focus on realistic physics and low graphics requirements. It is a fork of the game "Search and Rescue" (http://searchandrescue.sf.net), originally developed by Wolfpack Entertainment.
I'll do the review. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
+ Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistent macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: f91efe02165f371bd2ba8cb452a29677 sar2-2.3.0.tar.bz2 - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot + Package is code or permissible content. - Doc subpackage needed/used. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. + Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. - Package owns all the directories it creates. + No rpmlint output. + final provides and requires are sane: [elad@elephant result]$ for i in sar*rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done sar2-2.3.0-1.fc16.src.rpm = scons desktop-file-utils libX11-devel libSM-devel libXi-devel libXmu-devel SDL-devel SDL_image-devel openal-soft-devel freealut-devel mesa-libGLU-devel mesa-libGL-devel libICE-devel libXpm-devel libvorbis-devel libXext-devel rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 sar2-2.3.0-1.fc16.x86_64.rpm sar2 = 2.3.0-1.fc16 sar2(x86-64) = 2.3.0-1.fc16 = libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSDL-1.2.so.0()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXmu.so.6()(64bit) libXpm.so.4()(64bit) libalut.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.7)(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libopenal.so.1()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libstdc++.so.6()(64bit) libvorbisfile.so.3()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 sar2-debuginfo-2.3.0-1.fc16.x86_64.rpm sar2-debuginfo = 2.3.0-1.fc16 sar2-debuginfo(x86-64) = 2.3.0-1.fc16 = rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 SHOULD Items: + Should build in mock. - Should build on all supported archs + Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version All good, APPROVED -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
New Package SCM Request ======================= Package Name: sar2 Short Description: An open source helicopter simulator Owners: spot Branches: f14 f15 f16 devel InitialCC:
Git done (by process-git-requests). OMGOMGOMGOMGOMGOMG I've been trying to get the original to build for *years* thankyouthankyouthankyou <happydance>!!!!!!! Sincerely, Jon
sar2-2.3.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sar2-2.3.0-1.fc15
sar2-2.3.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/sar2-2.3.0-1.fc16
sar2-2.3.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/sar2-2.3.0-1.fc14
I built and installed your SRPM on one of my systems, and I see no icon. You should update icon cache in post and postun.
. . .running it manually didn't help. Hmmm.
sar2-2.3.0-2.fc16 has been pushed to the Fedora 16 testing repository.
sar2-2.3.0-2.fc14 has been pushed to the Fedora 14 stable repository.
sar2-2.3.0-2.fc15 has been pushed to the Fedora 15 stable repository.
sar2-2.3.0-2.fc16 has been pushed to the Fedora 16 stable repository.