Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.0-1.f14.src.rpm Description: A tool for managing RPM package sources in a git repository
this needs changing from %files -n pyrpkg %doc COPYING README # For noarch packages: sitelib %{python_sitelib}/* to %files -n pyrpkg %defattr(-,root,root,-) %doc COPYING README %{python_sitelib}/pyrpkg %{python_sitelib}/rpkg-1.0-py?.?.egg-info as far as I know you should remove the comment from "rm -rf $RPM_BUILD_ROOT" in the install section. make these changes and I will approve it
Another point BuildArch: noarch BuildRequires: python-devel, python-setuptools # We br these things for man page generation due to imports BuildRequires: GitPython, koji, python-pycurl %if 0%{?rhel} == 5 || 0%{?rhel} == 4 BuildRequires: python-hashlib BuildRequires: python-argparse %endif needs to be BuildArch: noarch BuildRequires: python-devel, python-setuptools # We br these things for man page generation due to imports BuildRequires: GitPython, koji, python-pycurl %if 0%{?rhel} == 6 || 0%{?rhel} == 4 BuildRequires: python-hashlib BuildRequires: python-argparse %endif to build on RHEL6
Good catches. That's what I get for uploading specs late at night. New stuff uploaded: Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.0-2.f14.src.rpm the defattr stuff is actually not necessary anymore. Rpm since 4.4 has a sane default.
(In reply to comment #3) > the defattr stuff is actually not necessary anymore. Rpm since 4.4 has a sane > default. Thanks for the info. Sadly rpmlint on el6 still sees it as a error (when I get time I will file a bugreport against rpmlint). [leigh@main_pc SPECS]$ rpmlint rpkg-1.0-1.el6.src.rpm rpkg.src: I: enchant-dictionary-not-found en_US rpkg.src:74: E: files-attr-not-set rpkg.src:75: E: files-attr-not-set rpkg.src:76: E: files-attr-not-set P.S you forgot to update the spec file
Do you have a proxy or something setup? I did put a new spec file up there, and just checked it in my browser, it has the right content.
Make that: Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.1-1.f14.src.rpm
Ahem. Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.1-2.f14.src.rpm
source sha1sum matches upstream spec file conforms to packaging guide lines licence is acceptable and correct builds ok @ koji for F16 http://koji.fedoraproject.org/koji/taskinfo?taskID=3139353 Package approved
New Package SCM Request ======================= Package Name: rpkg Short Description: Utility for interacting with rpm+git packaging systems Owners: jkeating Branches: f14 f15 el6 el5 InitialCC:
Git done (by process-git-requests).
Built for rawhide.