Hide Forgot
while try to rebuild libvirt-0.8.7-18.el6.src.rpm it fail since during the check commandtest failed in mock: -------------------------- TEST: commandtest ..!!.!!!!!!!!!!!... 19 FAIL FAIL: commandtest -------------------------- anyway during the test this warning also would be useful to fix (very simple): ------------------------------------------- CC hashtest.o hashtest.c: In function 'testHashRemoveForEach': hashtest.c:115: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat] -------------------------------------------
what's more it's not so simple to add like this --------------------------- %check cd tests # The following test doesn't currently work in a mock build root for i in daemon-conf command do rm -f $i printf "#!/bin/sh\nexit 0\n" > $i chmod +x $i done make check --------------------------- since commandtest is not a shell script, but compiled during the make check:-(
the x86_64 build failed even with rpmbuild in another test: ---------------------------------- TEST: qemuxml2argvtest ........................................ 40 ........................................ 80 ........................................ 120 ..!.!!!!!.. 131 FAIL FAIL: qemuxml2argvtest ---------------------------------- it'd be nice in case of fail to dump some kind of detailed info about the fail...
Hi Levente, agreed we should try to fix this, I'm wondering if there is a way to detect that we are within a mock buildroot to minimize the impact, any idea ? Daniel
try to check /dev/pts/0 or /dev/tty0. if it's not exist than it's probably mock.
Levente, if this is still a problem for you, can you submit a patch upstream to fix it?
imho it's fixed in 6.2 but not in 5.7. i simple remove virshtest from this line in the spec: for i in nodeinfotest daemon-conf seclabeltest virshtest
Libvirt has been buildable in mock for a long while, so closing