Bug 715215 - RFE: add v7-qa rpm for qa tests
Summary: RFE: add v7-qa rpm for qa tests
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Hardware Certification Program
Classification: Retired
Component: Test Suite (tests)
Version: 1.3
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
: ---
Assignee: Caspar Zhang
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
: 638819 638822 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-22 08:27 UTC by Caspar Zhang
Modified: 2011-10-24 06:06 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-27 15:08:08 UTC


Attachments (Terms of Use)

Description Caspar Zhang 2011-06-22 08:27:02 UTC
Description of problem:

This bug is open for tracking qa rpm issue, which is similar to bug 702695. More details will be added.

Comment 1 Caspar Zhang 2011-06-22 13:04:32 UTC
I have built a patch on my own repo: http://git.engineering.redhat.com/?p=users/czhang/v7.git;a=commitdiff;h=31cc80ab0cf9719461806ff37647214a09dda67f (but not tested yet)

Comment 3 Greg Nichols 2011-07-07 15:59:13 UTC
Since Comment 1, I've changed the v7-server package to be a subpackage, and I'd suggest we do the same for v7-qa.

We should probably think a bit about the naming.  v7-qa seems a bit generic, but maybe that's ok.

Comment 4 Caspar Zhang 2011-07-18 15:02:29 UTC
(In reply to comment #3)
> Since Comment 1, I've changed the v7-server package to be a subpackage, and I'd
> suggest we do the same for v7-qa.

Since QE will be the person who maintain qa tests in most cases, I'm suggesting less coupling between v7/v7-server and v7-qa. I put all Makefile changes to a file named Makefile.osqa and in Makefile we just "include Makefile.osqa". This is easy for Greg to do some modifications in Makefile and not break either v7 or v7-qa package.

> 
> We should probably think a bit about the naming.  v7-qa seems a bit generic,
> but maybe that's ok.

I see a tag named "osqa", so I changed the name to v7-osqa.


New version:
http://git.engineering.redhat.com/?p=users/czhang/v7.git;a=shortlog;h=osqa

I have tested osqa package and it worked well.

Comment 5 Greg Nichols 2011-07-19 15:28:34 UTC
(In reply to comment #4)

> Since QE will be the person who maintain qa tests in most cases, I'm suggesting
> less coupling between v7/v7-server and v7-qa. I put all Makefile changes to a
> file named Makefile.osqa and in Makefile we just "include Makefile.osqa". This
> is easy for Greg to do some modifications in Makefile and not break either v7
> or v7-qa package.

I'm not sure how making v7-qa a separate package really changes the coupling.  These tests use library code (/v7/v7), for example.  

If v7-qa is going to be in a different repo, all you'd need is a Makefile/packaging to install the test code under v7's test library directory (defined in /etc/v7.xml, default: /usr/share/v7/tests).   Test classes that are subclassed off of v7/test.py, and are in the test library directory will automatically be picked up by v7 at plan time.  There's no need to patch v7 for this.

That said, I think it would be better to keep all the tests in the same repo, built via the same brew builds, etc. And if the code is in a single repo, subpackages are a lot simpler to maintain.

Comment 6 Greg Nichols 2011-07-27 15:08:08 UTC
I'm closing this as it seems the best path is to have v7-qa a completely separaate source and package that depends on v7.   v7-qa can be developed with no changes necessary for v7.

Comment 7 Caspar Zhang 2011-10-24 06:06:38 UTC
*** Bug 638822 has been marked as a duplicate of this bug. ***

Comment 8 Caspar Zhang 2011-10-24 06:06:44 UTC
*** Bug 638819 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.