Hide Forgot
Description of problem: This issue is introduced by libvirt-Support-seemless-migration-of-SPICE-graphics-clients.patch, the function qemuMonitorJSONMigrateCancel is using variable 'type', 'hostname', 'port', 'tlsPort' and 'tlsSubject', however, these variables haven't been declared before usage, so will meet compile error when run 'make'. Version-Release number of selected component (if applicable): libvirt-0.9.2-1.el6.src.rpm How reproducible: always Steps to Reproduce: 1. rpm -ivh http://download.devel.redhat.com/brewroot/packages/libvirt/0.9.2/1.el6/src/libvirt-0.9.2-1.el6.src.rpm 2. /root/rpmbuild/SOURCES/libvirt-0.9.2 3. apply all of pathes under the /root/rpmbuild/SOURCES dir 4. compile libvirt source code Actual results: CC libvirt_driver_qemu_la-qemu_monitor_json.lo qemu/qemu_monitor_json.c: In function 'qemuMonitorJSONMigrateCancel': qemu/qemu_monitor_json.c:1946: error: 'type' undeclared (first use in this function) qemu/qemu_monitor_json.c:1946: error: (Each undeclared identifier is reported only once qemu/qemu_monitor_json.c:1946: error: for each function it appears in.) qemu/qemu_monitor_json.c:1953: error: 'hostname' undeclared (first use in this function) qemu/qemu_monitor_json.c:1954: error: 'port' undeclared (first use in this function) qemu/qemu_monitor_json.c:1955: error: 'tlsPort' undeclared (first use in this function) qemu/qemu_monitor_json.c:1956: error: 'tlsSubject' undeclared (first use in this function) Expected results: Fix it. Additional info: I try to apply a patch to fix this issue, it's okay to add the corresponding variables declaration for src/qemu/qemu_monitor.h, src/qemu/qemu_monitor.c, src/qemu/qemu_monitor_json.h and src/qemu/qemu_monitor_json.c, however, I find the qemuMonitorMigrateCancel function is called by qemuMigrationProcessJobSignals function in src/qemu/qemu_migration.c, that means I need to modify qemuMigrationProcessJobSignals function interface, meanwhile, I need also to update other function interface such as qemuMigrationWaitForCompletion, it's not good idea.
The root reason is patches applied sequence issue, I haven't followed patches sequence in SPECS/libvirt.spec, hence I met the above issue, the normal patches sequence look like this: # Patches Patch1: libvirt-Turn-on-JSON-mode-and-netdev-usage-for-RHEL6-binary.patch Patch2: libvirt-Support-virtio-disk-hotplug-in-JSON-mode.patch Patch3: libvirt-Support-password-expiry-in-the-QEMU-driver.patch Patch4: libvirt-Support-seemless-migration-of-SPICE-graphics-clients.patch Patch5: libvirt-Emit-graphics-events-when-a-SPICE-client-connects-disconnects.patch Patch6: libvirt-Switch-to-private-redhat-namespace-for-QMP-I-O-error-reason.patch Patch7: libvirt-Disable-KSM-on-domain-startup.patch Changing the bug to NOTABUG. Alex