Bug 715575 - ACPI SPMI table definition does not follow IPMI specification
Summary: ACPI SPMI table definition does not follow IPMI specification
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Red Hat Kernel Manager
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-23 11:59 UTC by Jan Holčapek
Modified: 2011-10-12 08:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-27 17:42:07 UTC
Target Upstream Version:


Attachments (Terms of Use)
Patch to fix SPMITable struct. (1011 bytes, patch)
2011-06-23 11:59 UTC, Jan Holčapek
no flags Details | Diff

Description Jan Holčapek 2011-06-23 11:59:25 UTC
Created attachment 506215 [details]
Patch to fix SPMITable struct.

Description of problem:

drivers/char/ipmi/ipmi_si_intf.c:

struct SPMITable {
        s8      Signature[4];
        u32     Length;
        u8      Revision;
        u8      Checksum;
        s8      OEMID[6];
        s8      OEMTableID[8];
        s8      OEMRevision[4];
        s8      CreatorID[4];
        s8      CreatorRevision[4];
        u8      InterfaceType;
        u8      IPMIlegacy;
        s16     SpecificationRevision;
[...]

According to ftp://download.intel.com/design/servers/ipmi/IPMIv2_0rev1_0.pdf
(and also http://sysdoc.doors.ch/HP/hpspmi.pdf formerly referenced
in the sources), the order of SPMITable.{IPMIlegacy,Interface} is wrong.
The structure should be like this:

struct SPMITable {
        s8      Signature[4];
        u32     Length;
        u8      Revision;
        u8      Checksum;
        s8      OEMID[6];
        s8      OEMTableID[8];
        s8      OEMRevision[4];
        s8      CreatorID[4];
        s8      CreatorRevision[4];
        u8      IPMIlegacy;     <=== these two
        u8      InterfaceType;  <=== swapped
        s16     SpecificationRevision;
[...]

Comment 1 Jan Holčapek 2011-06-27 08:11:23 UTC
It seems I spoke to soon: the latest IPMI specificatin errata at http://download.intel.com/design/servers/ipmi/IPMI2_0E4_061209.pdf
shows the order of SPMITable.{InterfaceType,IPMILegacy} is correct in the sources.
Thus, this is not a bug.

Comment 3 Prarit Bhargava 2011-06-27 17:42:07 UTC
Closing based on comment #1.

P.


Note You need to log in before you can comment on or make changes to this bug.